New issue
Advanced search Search tips

Issue 827376 link

Starred by 2 users
Status: Fixed
Owner:
agawronska@chromium.org
Closed: Aug 6
Cc:
agawronska@chromium.org
r...@chromium.org
tbarzic@chromium.org
ovanieva@chromium.org
mukai@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 842264
issue 857519
issue 862445
Blocking:
issue 812037



Sign in to add a comment

[Demo mode] Implement demo setup UI

Project Member Reported by agawronska@chromium.org, Mar 29 2018 
Once mocks are delivered the temporary UI needs to be replaced.

Current plan for UX:
* Confirmation dialog - Do you want to setup demo mode? Y/N
* Settings page - Choose language, network or offline mode
* Progress and result page - demo mode in progress, finished successfully, error

Comment 1 by agawronska@chromium.org, Mar 29 2018

Components: -Platform>Apps>Demo UI>Shell>DemoMode

Comment 2 by agawronska@chromium.org, Apr 23 2018

Cc: agawronska@chromium.org tbarzic@chromium.org mukai@chromium.org
 Issue 835898  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9686aa1eec2b1992c5e74d94babf483a6c062fca

commit 9686aa1eec2b1992c5e74d94babf483a6c062fca
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Apr 26 22:06:58 2018

demo mode: Move Demo Mode setup entry point to first OOBE screen.

Change done according to mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z

Bug:  827376 
Change-Id: I48e7145a4dbcd8400ef96411e7903a2bb5af9064
Reviewed-on: https://chromium-review.googlesource.com/1026995
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554163}
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/app_launch_signin_screen.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/ui/login_display.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/ui/login_display_webui.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/ui/login_display_webui.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/9686aa1eec2b1992c5e74d94babf483a6c062fca/ui/login/display_manager.js

Comment 5 by agawronska@chromium.org, May 14 2018

Labels: -M-68 M-69

Comment 6 by michae...@chromium.org, May 25 2018

Blocking: 846802

Comment 7 by michae...@chromium.org, May 25 2018

Labels: OS-Chrome

Comment 8 by michae...@chromium.org, Jun 4 2018

Blockedon: 842264
Labels: -Type-Bug Type-Feature

Comment 9 by agawronska@chromium.org, Jun 5 2018

Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca9e6497399c4addabcc06ad20c61fe91a41760

commit 3ca9e6497399c4addabcc06ad20c61fe91a41760
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jun 08 04:41:00 2018

Revert "Display confirmation dialog before proceeding to Demo Mode Setup flow."

This reverts commit 11732507f68037dc551a2f4590242adb5cccb915.

Reason for revert: New browser_test is failing on linux-chromeos-rel.

Original change's description:
> Display confirmation dialog before proceeding to Demo Mode Setup flow.
> 
> The dialog is not styled yet.
> UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOe9oB6rGBuYSwMSJbxAVNpw
> 
> Test: Run DemoSetupTest.
> Bug:  827376 
> Change-Id: I58a051e3b9149472ff616aca791e7d8798f9b9fa
> Reviewed-on: https://chromium-review.googlesource.com/1087594
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565518}

TBR=xiyuan@chromium.org,jcivelli@chromium.org,agawronska@chromium.org

Change-Id: I51160678e1952a3fbb0e0f048c00e2eda5a9f2c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  827376 
Reviewed-on: https://chromium-review.googlesource.com/1092330
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565531}
[modify] https://crrev.com/3ca9e6497399c4addabcc06ad20c61fe91a41760/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/3ca9e6497399c4addabcc06ad20c61fe91a41760/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/3ca9e6497399c4addabcc06ad20c61fe91a41760/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/3ca9e6497399c4addabcc06ad20c61fe91a41760/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/3ca9e6497399c4addabcc06ad20c61fe91a41760/ui/login/display_manager.js
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90

commit afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90
Author: Aga Wronska <agawronska@chromium.org>
Date: Tue Jun 12 16:48:25 2018

Reland "Display confirmation dialog before proceeding to Demo Mode Setup flow."

This is a reland of 11732507f68037dc551a2f4590242adb5cccb915

Original change's description:
> Display confirmation dialog before proceeding to Demo Mode Setup flow.
>
> The dialog is not styled yet.
> UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOe9oB6rGBuYSwMSJbxAVNpw
>
> Test: Run DemoSetupTest.
> Bug:  827376 
> Change-Id: I58a051e3b9149472ff616aca791e7d8798f9b9fa
> Reviewed-on: https://chromium-review.googlesource.com/1087594
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565518}

Bug:  827376 
Change-Id: I34f256378bcea8f2d161690cb0e5d6ab80fc56b2
Reviewed-on: https://chromium-review.googlesource.com/1095681
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566464}
[modify] https://crrev.com/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/afdeb5131eb9ce474f9b636b7dbad56a2bcd0d90/ui/login/display_manager.js
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c618b6e7c717459d8f853c61904e4a53314ed17c

commit c618b6e7c717459d8f853c61904e4a53314ed17c
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Jun 28 15:38:18 2018

Add skeleton of Demo Mode setup UI.

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z

Bug:  827376 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
Reviewed-on: https://chromium-review.googlesource.com/1100237
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571137}
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[add] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/screens/demo_setup_screen_view.h
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.h
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
[modify] https://crrev.com/c618b6e7c717459d8f853c61904e4a53314ed17c/chrome/test/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7e073e5b0bf2f6846f3c35a87ac813631983a5

commit 1f7e073e5b0bf2f6846f3c35a87ac813631983a5
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Jun 28 18:09:55 2018

Implement content of progress and error dialogs according to mocks.

Bug:  827376 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828
Reviewed-on: https://chromium-review.googlesource.com/1105568
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571202}
[modify] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/resources/chromeos/login/demo_setup.js
[add] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/resources/chromeos/login/images/alert-illustration_1x.svg
[add] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/resources/chromeos/login/images/alert-illustration_2x.svg
[modify] https://crrev.com/1f7e073e5b0bf2f6846f3c35a87ac813631983a5/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76

commit 4c2ee1dc602ae4e8e55af5cf0de11bec04188f76
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Thu Jun 28 21:57:24 2018

Revert "Implement content of progress and error dialogs according to mocks."

This reverts commit 1f7e073e5b0bf2f6846f3c35a87ac813631983a5.

Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one.

Original change's description:
> Implement content of progress and error dialogs according to mocks.
> 
> Bug:  827376 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828
> Reviewed-on: https://chromium-review.googlesource.com/1105568
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571202}

TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org

Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  827376 ,  858817 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119267
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571283}
[modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.js
[delete] https://crrev.com/89b548a0bae43ef770c8e82a0e396d08c0cc53d4/chrome/browser/resources/chromeos/login/images/alert-illustration_1x.svg
[delete] https://crrev.com/89b548a0bae43ef770c8e82a0e396d08c0cc53d4/chrome/browser/resources/chromeos/login/images/alert-illustration_2x.svg
[modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f25b9378c776fcb305f4204733045c565a800f

commit 19f25b9378c776fcb305f4204733045c565a800f
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Thu Jun 28 21:59:45 2018

Revert "Add skeleton of Demo Mode setup UI."

This reverts commit c618b6e7c717459d8f853c61904e4a53314ed17c.

Reason for revert: Revert 2 of 2 - FindIt flagged this CL with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); had to revert https://chromium-review.googlesource.com/1105568 first to be able to revert this one.

Original change's description:
> Add skeleton of Demo Mode setup UI.
> 
> Mocks:
> https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z
> 
> Bug:  827376 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
> Reviewed-on: https://chromium-review.googlesource.com/1100237
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571137}

TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org

Change-Id: I49ab0b951ced812d56f5fc14e953da854f085b50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  827376 ,  858817 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119305
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571285}
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[delete] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/demo_setup_screen_view.h
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.h
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
[modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/test/BUILD.gn

Comment 18 by michae...@chromium.org, Jun 28 2018

Blocking: -846802 812037
Components: UI>Shell>OOBE

Comment 19 by michae...@chromium.org, Jun 28 2018

Blockedon: 857519
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206531abf0559e63218085627f0f66f32409bbae

commit 206531abf0559e63218085627f0f66f32409bbae
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Jun 29 21:57:47 2018

Reland "Add skeleton of Demo Mode setup UI."

This is a reland of c618b6e7c717459d8f853c61904e4a53314ed17c

Original change's description:
> Add skeleton of Demo Mode setup UI.
>
> Mocks:
> https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z
>
> Bug:  827376 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
> Reviewed-on: https://chromium-review.googlesource.com/1100237
> Commit-Queue: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571137}

Bug:  827376 
Change-Id: I8f4d81e2e10437b23cd4c84eac95204600fb28ee
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119268
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571659}
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[add] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/screens/demo_setup_screen_view.h
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.h
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
[modify] https://crrev.com/206531abf0559e63218085627f0f66f32409bbae/chrome/test/BUILD.gn
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2

commit e29f5b811c91c64c97a0e71c8d3436d02a37e9f2
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Jun 29 22:07:24 2018

Reland "Implement content of progress and error dialogs according to mocks."

This reverts commit 4c2ee1dc602ae4e8e55af5cf0de11bec04188f76.

Original change's description:
> Revert "Implement content of progress and error dialogs according to mocks."
>
> This reverts commit 1f7e073e5b0bf2f6846f3c35a87ac813631983a5.
>
> Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one.
>
> Original change's description:
> > Implement content of progress and error dialogs according to mocks.
> >
> > Bug:  827376 
> > Cq-Include-Trybots: luci.chromium.try:closure_compilation
> > Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828
> > Reviewed-on: https://chromium-review.googlesource.com/1105568
> > Commit-Queue: Aga Wronska <agawronska@chromium.org>
> > Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> > Reviewed-by: Jun Mukai <mukai@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#571202}
>
> TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org
>
> Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  827376 ,  858817 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/1119267
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571283}

Change-Id: I80071a9c745712e4e9f5b58c730edfb1f3d716e7
Bug:  827376 ,  858817 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1119269
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571664}
[modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.js
[add] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/images/alert-illustration_1x.svg
[add] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/images/alert-illustration_2x.svg
[modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4866e82aea13556ad37e6ebcc6a933ce9266b7f6

commit 4866e82aea13556ad37e6ebcc6a933ce9266b7f6
Author: Aga Wronska <agawronska@chromium.org>
Date: Mon Jul 09 18:54:03 2018

Add initial Demo Mode preferences screen.

Mock:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHiVGjUR16sLc0S1m6c9nL_wMSJbxAVNpw

Bug:  827376 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10151db7eb9dc586af5987815e31abd72c8aa309
Reviewed-on: https://chromium-review.googlesource.com/1106804
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573394}
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/screens/demo_preferences_screen.cc
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/screens/demo_preferences_screen.h
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/screens/demo_preferences_screen_view.cc
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/screens/demo_preferences_screen_view.h
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/demo_preferences.css
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/demo_preferences.html
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/demo_preferences.js
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/oobe.js
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/oobe_screen_demo_preferences.html
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/oobe_screen_demo_preferences.js
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/resources/chromeos/login/oobe_screens.html
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/ui/webui/chromeos/login/demo_preferences_screen_handler.cc
[add] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/ui/webui/chromeos/login/demo_preferences_screen_handler.h
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/4866e82aea13556ad37e6ebcc6a933ce9266b7f6/ui/login/display_manager.js
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514bc3e3457a40bc2caec1eab08db394a7134093

commit 514bc3e3457a40bc2caec1eab08db394a7134093
Author: Aga Wronska <agawronska@chromium.org>
Date: Mon Jul 09 22:32:50 2018

Add Demo Mode setup flow to OOBE WizardController.

Right now flow consists of:
* Demo preferences screen where user can select language related options
* Chrome OS Eula that has to be accepted
* Demo setup screen that shows progress and result of demo setup
More screens will be added later.

BUG= 827376 
TEST=Run tests in wizard_controller_browsertest.cc

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifa4c86201a0ef7b0a6c41b5805ba0c3fde1d791a
Reviewed-on: https://chromium-review.googlesource.com/1108356
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573489}
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/screens/demo_preferences_screen.cc
[add] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/screens/mock_demo_preferences_screen.cc
[add] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/screens/mock_demo_preferences_screen.h
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/514bc3e3457a40bc2caec1eab08db394a7134093/chrome/test/BUILD.gn

Comment 24 by agawronska@chromium.org, Jul 10

Blockedon: 862445
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21e30fd064d14c773afdec2c6ae4409953000f86

commit 21e30fd064d14c773afdec2c6ae4409953000f86
Author: Aga Wronska <agawronska@chromium.org>
Date: Sat Jul 14 05:30:08 2018

Show Play Store terms of service in demo mode setup flow.

Bug:  827376 
Test: Run DemoSetpTest and WizardController browser tests.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0decf05a353fa8e76823b286e3442d6c0bf98814
Reviewed-on: https://chromium-review.googlesource.com/1116246
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575153}
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/arc/arc_util.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h
[add] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/mock_arc_terms_of_service_screen.cc
[add] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/mock_arc_terms_of_service_screen.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/resources/chromeos/login/arc_terms_of_service.css
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/resources/chromeos/login/arc_terms_of_service.html
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/resources/chromeos/login/arc_terms_of_service.js
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/resources/chromeos/login/demo_preferences.html
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h
[modify] https://crrev.com/21e30fd064d14c773afdec2c6ae4409953000f86/chrome/test/BUILD.gn

Comment 26 by agawronska@chromium.org, Jul 31

Labels: -M-69 M-70

Comment 27 by agawronska@chromium.org, Aug 6

Status: Fixed (was: Started)
►

Sign in to add a comment