Spacey: Don't comment on mixed spaces in Makefiles |
||
Issue descriptionExample CL with lots of spammy comments: https://chromium-review.googlesource.com/c/infra/infra/+/986940/3 Spacey should have different rules for whitespace in Makefiles; or we could have it not run on Makefiles. Related thought; If there are *lots* of comments in one file, we could consider just adding one file-level comment.
,
Mar 29 2018
We have seen the same issue in Fuchsia: https://fuchsia-review.googlesource.com/c/zircon/+/136631
,
Mar 29 2018
Sure, I can take a look.
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3828e040a3836ac4027d43b983a125956282b508 commit 3828e040a3836ac4027d43b983a125956282b508 Author: Julie Hockett <juliehockett@google.com> Date: Fri Mar 30 01:39:42 2018 [tricium] Updating Spacey to not flag mixed whitespace in Makefiles Bug: 827345 Change-Id: I6cfb522d31c35b5db58eb97fe945d74cf215a5b9 Reviewed-on: https://chromium-review.googlesource.com/986624 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/3828e040a3836ac4027d43b983a125956282b508/go/src/infra/tricium/functions/spacey/spacey.go [modify] https://crrev.com/3828e040a3836ac4027d43b983a125956282b508/go/src/infra/tricium/functions/spacey/spacey_test.go
,
Mar 30 2018
Deployed new version of Spacey, and verified the fix -- Thanks Julie! https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/988292 |
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Mar 29 2018