New issue
Advanced search Search tips

Issue 827337 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove blob acking from CacheStorage

Project Member Reported by mek@chromium.org, Mar 29 2018

Issue description

No longer needed since the SWResponse objects themselves keep blobs alive with mojo blobs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858785e670548b3fd9169a195c8666d9819498f0

commit 858785e670548b3fd9169a195c8666d9819498f0
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Mar 30 18:03:31 2018

[CacheStorage] Remove blob acking.

The IPC messages contain a BlobPtr, so blobs are guaranteed to stay alive
already. Also cleanup a bunch of internal code that passes around a
BlobDataHandle in addition to a ServiceWorkerResponse, since the response
object itself already holds a BlobPtr.

Finally this required adding a ReadSideData method to the Blob mojom
interface, in this case only used by tests.

Bug:  827337 
Change-Id: Ieb05ae545631659e303d4933c2fafa9205b6fa43
Reviewed-on: https://chromium-review.googlesource.com/986948
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547205}
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/storage/browser/blob/blob_impl.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/storage/browser/blob/blob_impl.h
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/storage/browser/blob/blob_registry_impl_unittest.cc
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/third_party/WebKit/Source/platform/blob/testing/FakeBlob.cpp
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/third_party/WebKit/Source/platform/blob/testing/FakeBlob.h
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/third_party/WebKit/public/mojom/blob/blob.mojom
[modify] https://crrev.com/858785e670548b3fd9169a195c8666d9819498f0/third_party/WebKit/public/platform/modules/cache_storage/cache_storage.mojom

Comment 2 by mek@chromium.org, Mar 30 2018

Status: Fixed (was: Started)

Sign in to add a comment