Mash: enable viz |
||||
Issue descriptionViz doesn't work with mash. With videos using SurfaceLayer, that means that videos are broken. Tests are failing with the following crashes: ``` base::debug::StackTrace::StackTrace() #1 0x0000049784c5 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fdbb56d7cb0 <unknown> #3 0x00000623357c base::flat_map<>::operator[]() #4 0x000006233462 viz::HostFrameSinkManager::RegisterFrameSinkId() #5 0x000002deedd3 content::OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl() #6 0x000002dedac7 content::OffscreenCanvasProviderImpl::CreateOffscreenCanvasSurface() ```
,
Aug 13
What is the current stack-trace for the crashes? I can't find OffscreenCanvasProviderImpl or OffscreenCanvasSurfaceImpl in the code anymore. The browser is able to embed a renderer or exo apps using SurfaceLayer with mash. So there is not fundamental reasons this can't work for pip-videos. I suspect some rewiring needs to happen though. See how the frame-sinks are registered in regular-chrome in WindowPortLocal::CreateLayerTreeFrameSink [1] vs. how it's done with mus in WindowPortMus [2]. I suspect something similar to the latter needs to happen for pip-videos too. [1] https://cs.chromium.org/chromium/src/ui/aura/local/window_port_local.cc?l=149 [2] https://cs.chromium.org/chromium/src/ui/aura/mus/window_port_mus.cc?l=108
,
Sep 5
,
Sep 24
Design doc in progress: https://docs.google.com/document/d/1FJgJeGDqYZag96URfI5VyyCzhRnj1dZ2u3G2Lov7C_0/edit#
,
Sep 24
,
Sep 24
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jamescook@chromium.org
, Apr 24 2018