Cros splitscreen - Disable spltiscreen on M66 stable but keep it enabled for other channels |
||||||||
Issue descriptionSee launch bug Issue 789304. Splitscreen was punted to M67. However, per the PM's request, we'll disable it by default on M66 stable but keep it enabled for other channels to keep receiving users feedback.
,
Mar 30 2018
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3 commit f1a2e94f6bfc0506020a308fc1f5458278bbb0f3 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Mar 30 20:49:41 2018 Revert "Cros splitscreen: Disable splitscreen on M66 stable channel." This reverts commit a87712b1a0634e8851c9060b9ccc67ee7db0ddc0. Reason for revert: A misspelled string broke the build. Will reland it later. Original change's description: > Cros splitscreen: Disable splitscreen on M66 stable channel. > > Per PM's request, disable splitscreen on M66 stable channel. > This CL will be merged back to M66 and then reverted later on tot. > > Bug: 827322 > Change-Id: If1d4af68dc64a9f37e93cd7e48056714fda2206a > Reviewed-on: https://chromium-review.googlesource.com/985092 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547252} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I54934161f37be5bfe09d4f91b24a0c6518b51ea3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827322 Reviewed-on: https://chromium-review.googlesource.com/988672 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547260} [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/ash/public/cpp/ash_switches.h [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/chrome/browser/about_flags.cc [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/chrome/browser/flag_descriptions.h [modify] https://crrev.com/f1a2e94f6bfc0506020a308fc1f5458278bbb0f3/tools/metrics/histograms/enums.xml
,
Mar 31 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 2 2018
When we have a CL landed that we can pick back we can review the merge again.
,
Apr 2 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf5e5473412073d5d52476c456eed66386483e58 commit cf5e5473412073d5d52476c456eed66386483e58 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Apr 03 21:52:38 2018 [reland] Cros splitscreen: Disable splitscreen on M66 stable channel. Per PM's request, disable splitscreen on M66 stable channel. This CL will be merged back to M66 and then reverted later on tot. TBR=xiyuan@chromium.org Bug: 827322 Change-Id: I0040d7a8e98841fee1808fe3a0589dd3c8b384ef Reviewed-on: https://chromium-review.googlesource.com/993472 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547844} [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/ash/public/cpp/ash_switches.h [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/chrome/browser/about_flags.cc [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/chrome/browser/flag_descriptions.h [modify] https://crrev.com/cf5e5473412073d5d52476c456eed66386483e58/tools/metrics/histograms/enums.xml
,
Apr 3 2018
,
Apr 3 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902 commit a1aeafbed0b16aa41316b8c5ceb8cec75aa60902 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Apr 06 18:10:35 2018 [Merge to M66] Cros splitscreen: Disable splitscreen on M66 stable channel. Per PM's request, disable splitscreen on M66 stable channel. This CL will be merged back to M66 and then reverted later on tot. TBR=xiyuan@chromium.org (cherry picked from commit cf5e5473412073d5d52476c456eed66386483e58) Bug: 827322 Change-Id: I0040d7a8e98841fee1808fe3a0589dd3c8b384ef Reviewed-on: https://chromium-review.googlesource.com/993472 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547844} Reviewed-on: https://chromium-review.googlesource.com/999954 Cr-Commit-Position: refs/branch-heads/3359@{#606} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/ash/public/cpp/ash_switches.h [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/chrome/browser/about_flags.cc [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/chrome/browser/flag_descriptions.h [modify] https://crrev.com/a1aeafbed0b16aa41316b8c5ceb8cec75aa60902/tools/metrics/histograms/enums.xml
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24b33eb76316693382e17ec3d55adcc3463cb24f commit 24b33eb76316693382e17ec3d55adcc3463cb24f Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Apr 10 21:01:57 2018 Revert "[reland] Cros splitscreen: Disable splitscreen on M66 stable channel." The CL has been merged back to M66. So revert this CL on tot. This reverts commit cf5e5473412073d5d52476c456eed66386483e58. TBR=xiyuan@chromium.org Bug: 827322 Change-Id: I9d5ca5abf7399318e5bf950c5e25d01bc2ff9093 Reviewed-on: https://chromium-review.googlesource.com/1005615 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#549640} [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/ash/public/cpp/ash_switches.h [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/chrome/browser/about_flags.cc [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/chrome/browser/flag_descriptions.h [modify] https://crrev.com/24b33eb76316693382e17ec3d55adcc3463cb24f/tools/metrics/histograms/enums.xml |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 30 2018