New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 827306 link

Starred by 2 users
Status: Duplicate
Merged: issue 827304
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
dbbrooks@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

WebVR Permission indicators - Press App button to exist should only be displayed on initial open of WebVR

Project Member Reported by dougman@chromium.org, Mar 29 2018 
Chrome Version: 67.0.3383.0 PR on Canary
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(0) Setup so user can allow permissions.
(1) Navigate to https://immersive-web.github.io/webxr-samples/tests/permission-request.html
(2) Enter WebVR, wait for permission list to disappear.
(3) Click the Camera icon, allow the permission.

What is the expected result?
The "Press App button to exist" should not be shown after allowing a new permission.

What happens instead?
The "Press App button to exist" is shown after allowing a new permission.
Screenshot_WebXR_Location.png
356 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1116d78013a12411b24a929b2ba8f3d53bb1bf6

commit c1116d78013a12411b24a929b2ba8f3d53bb1bf6
Author: Ian Vollick <vollick@chromium.org>
Date: Fri Mar 30 02:43:57 2018

[vr] Don't show security indicators after hosted UI

When in WebVR presentation, if we transition to metaworld to accept a
permission, when we return we should not show the permissions.

Bug:  827304 , 827306 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9280a04950dcc24f163be9f58fbf27c14c9ab6bd
Reviewed-on: https://chromium-review.googlesource.com/986290
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547080}
[modify] https://crrev.com/c1116d78013a12411b24a929b2ba8f3d53bb1bf6/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/c1116d78013a12411b24a929b2ba8f3d53bb1bf6/chrome/browser/vr/ui_unittest.cc

Comment 2 by vollick@chromium.org, Mar 30 2018

Mergedinto: 827304
Status: Duplicate (was: Assigned)
This bug is another manifestation of the issue where the indicators reappear unexpectedly after accepting/denying permissions from within WebVR.
►

Sign in to add a comment