WebVR Permission Indicators - Specific permission not displayed after allowing |
|||
Issue descriptionChrome Version: 67.0.3383.0 PR on Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (0) Setup so user can allow permissions. (1) Navigate to https://immersive-web.github.io/webxr-samples/tests/permission-request.html (2) Enter WebVR, wait for permission list to disappear. (3) Click the Camera icon, allow the permission. What is the expected result? The permission list should appear and have the just allowed permission listed. What happens instead? The just allowed is not listed. Attached image was taken after Location permission was allowed. Notice that Location is missing from the list.
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1116d78013a12411b24a929b2ba8f3d53bb1bf6 commit c1116d78013a12411b24a929b2ba8f3d53bb1bf6 Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 30 02:43:57 2018 [vr] Don't show security indicators after hosted UI When in WebVR presentation, if we transition to metaworld to accept a permission, when we return we should not show the permissions. Bug: 827304 , 827306 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9280a04950dcc24f163be9f58fbf27c14c9ab6bd Reviewed-on: https://chromium-review.googlesource.com/986290 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#547080} [modify] https://crrev.com/c1116d78013a12411b24a929b2ba8f3d53bb1bf6/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/c1116d78013a12411b24a929b2ba8f3d53bb1bf6/chrome/browser/vr/ui_unittest.cc
,
Mar 30 2018
It wasn't my intention to show the permissions again after accepting permissions when in WebVR. This broke recently causing these indicators to reappear when they weren't expecting it (and since they weren't expecting to appear, the wrong stuff would be in the list). This latest patch ensures that we only do the animate-in thing when we enter WebVR presentation so the situation described in the bug can't occur.
,
Mar 30 2018
,
Apr 6 2018
Fix Verified on build 67.0.3389.0. After granting a specific permission we do NOT display the list of permission toasts. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dougman@chromium.org
, Mar 29 2018