New issue
Advanced search Search tips

Issue 827290 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 812037



Sign in to add a comment

[Demo mode] Offline enrollment into demo domain

Project Member Reported by agawronska@chromium.org, Mar 29 2018

Issue description

Fake enrollment* and apply policy blobs stored on dm-verity partition.

* It is still discussed if we have to establish device ownership for offline enrollment.
This decision affects transition to online demo mode later on.

 
Blocking: 812037
Labels: -Pri-3 Pri-1

Comment 2 by r...@chromium.org, Mar 29 2018

Cc: tbarzic@chromium.org
Owner: mukai@chromium.org
Status: Assigned (was: Untriaged)
Labels: M-68
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc8a348c7495841917ba7b5c71cf31d9d387f75

commit bdc8a348c7495841917ba7b5c71cf31d9d387f75
Author: Jun Mukai <mukai@google.com>
Date: Wed Apr 25 00:26:27 2018

fake enrollment for offline demo mode

This adds a 'MODE_OFFLINE_DEMO' enrollment mode, which locks the
device and applies the policy in the local installation. This
is the flow to setup the offline demo mode.

Currently the actual policy data is not yet available, so this
right now simply locks the device.

Bug:  827290 
Change-Id: I6cdfec50049b017fc01d9875bd520f0655660031
Reviewed-on: https://chromium-review.googlesource.com/1000012
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553389}
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/enrollment/enrollment_uma.cc
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/login/screens/demo_setup_screen.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/policy/enrollment_config.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/bdc8a348c7495841917ba7b5c71cf31d9d387f75/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Labels: -M-68 M-69
Labels: -Type-Bug OS-Chrome Type-Feature
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39

commit 591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39
Author: Jun Mukai <mukai@google.com>
Date: Wed Jun 13 09:10:43 2018

load offline policy blob from the filesystem

This CL looks up the policy blob data for the offline demo mode
from the filesystem and goes through the enrollment flow.

Bug:  827290 
Change-Id: Id23959bb710a08db2ad64cf838b15a3b21457cef
Reviewed-on: https://chromium-review.googlesource.com/1048166
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566768}
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/login/screens/demo_setup_screen.h
[add] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/policy/enrollment_config.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/policy/enrollment_config.h
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/chromeos/policy/enrollment_status_chromeos.h
[modify] https://crrev.com/591fe7b9d4bcb1e4c28ae0084ba6676b42bcde39/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f94187dc901eb41d840279cf48931574a2827ceb

commit f94187dc901eb41d840279cf48931574a2827ceb
Author: Jun Mukai <mukai@google.com>
Date: Wed Jun 20 23:20:18 2018

change the failure types of the demo-mode setup flow

Currently OnSetupError receives a string for the details of the
error, and then it is printed out through LOG(ERROR).

This CL changes the interface so that OnSetupError just receives
a boolean, which indicates if the failure needs powerwash or not.
The logging of the details happens within DemoSetupController.

The flag is not used within CL. An upcoming CLL (on top of
I9b4fabbb6e87e921e305ccfe78e49e5eb172a10f) will consume this flag
and update the error message.

BUG= 827290 
TEST=unit_tests

Change-Id: I1942109a572eb09ed947ba67ac6cf946e8aa05a1
Reviewed-on: https://chromium-review.googlesource.com/1107011
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569079}
[modify] https://crrev.com/f94187dc901eb41d840279cf48931574a2827ceb/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/f94187dc901eb41d840279cf48931574a2827ceb/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/f94187dc901eb41d840279cf48931574a2827ceb/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc
[modify] https://crrev.com/f94187dc901eb41d840279cf48931574a2827ceb/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[modify] https://crrev.com/f94187dc901eb41d840279cf48931574a2827ceb/chrome/browser/chromeos/login/screens/demo_setup_screen.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/90d8115fe8c47711c5a2e23931c5e3da752ed12a

commit 90d8115fe8c47711c5a2e23931c5e3da752ed12a
Author: Jun Mukai <mukai@google.com>
Date: Tue Jun 26 23:59:36 2018

Status: Fixed (was: Started)
I think it's done. The offline enrollment is working.

Sign in to add a comment