New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827289 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] The Omnibox Drop Down is 1px too high.

Project Member Reported by meh...@chromium.org, Mar 29 2018

Issue description

Chrome Version: Canary 67.0.3383.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable chrome://flags/#views-browser-windows
(2) Open a new window
(3) Hide the Bookmarks Bar via SHIFT-CMD-B
(4) Type something into the Omnibox

What is the expected result?
The Omnibox Drop Down should be 1px lower to be aligned with the Toolbar bottom outline to match the current Cocoa behavior and to look cleaner.

What happens instead?
The Omnibox Drop Down is 1px too high.

Two screencasts actual vs expected are attached.

Thanks :-)
 
actual.mov
1.1 MB View Download

Comment 1 by meh...@chromium.org, Mar 29 2018

+expected screencast
expected.mov
804 KB View Download
It's likely MacViews Browser will ship initially with chrome://flags/#top-chrome-md = Refresh, so we might not need to worry about this.
Labels: M-68 MacViews-Browser Target-68
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
I don't know if we'll need to fix this before M69, but it's odd that the layout of the toolbar is changing when the popup opens... over to sdy@ for M68 :)

Comment 4 by sdy@chromium.org, Apr 16 2018

Labels: Sprint-1

Comment 5 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 6 by sdy@chromium.org, May 7 2018

Labels: -Sprint-1 Sprint-2

Comment 7 by gov...@chromium.org, May 11 2018

Any progress here?

Comment 8 by sdy@chromium.org, Jun 11 2018

Labels: Hotlist-Helper
Cc: sdy@chromium.org
Owner: tnijssen@google.com
Status: Started (was: Assigned)
Cc: pkasting@chromium.org
pkasting@ notified me that this is actually the expected behavior.

The layout of the toolbar isn't changing and the edge of the dropdown is actually aligned with the toolbar's bottom edge. The new gray line that appears is the dropdown's shadow, which is intentionally above the toolbar's bottom edge.
Status: WontFix (was: Started)
I agree that it's weird looking, but yeah, this is intentionally designed.

It's kinda immaterial since refresh replaces this UI anyway.

Sign in to add a comment