Issue 827271 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	mustaq@chromium.org
Closed:	Apr 2018
Cc:	nzolghadr@chromium.org dtapu...@chromium.org
Components:	Blink>Input
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	3
Type:	Bug
Hotlist-Input-Dev M-68 merge-merged-testbranch

PointerEvent.fromElement and .toElement should be null

Project Member Reported by mustaq@chromium.org, Mar 29 2018

Issue description

It was decided recently that PointerEvents shouldn't inherit these non-standard and inconsistent values from MouseEvents when we have better (standard and consistent) alternatives (.target and .relatedTarget).

https://github.com/w3c/pointerevents/issues/167

We should fix Chrome accordingly.

(For MouseEvents, see Issue 692709.)

Comment 1 by mustaq@chromium.org, Apr 11 2018

Status: Started (was: Assigned)

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86738ed0dece9f590ed93e7e0a58259bfa0c019c

commit 86738ed0dece9f590ed93e7e0a58259bfa0c019c
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri Apr 13 18:02:47 2018

Make PointerEvent fromElement/toElement return null.

Also added web-platform-tests.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA

Closes https://github.com/w3c/pointerevents/issues/167

Bug:  827271 
Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5
Reviewed-on: https://chromium-review.googlesource.com/986877
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550683}
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_support.js
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/mouse_event.h
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/pointer_event.cc
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/pointer_event.h

Comment 3 by mustaq@chromium.org, Apr 13 2018

Status: Fixed (was: Started)

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86738ed0dece9f590ed93e7e0a58259bfa0c019c

commit 86738ed0dece9f590ed93e7e0a58259bfa0c019c
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri Apr 13 18:02:47 2018

Make PointerEvent fromElement/toElement return null.

Also added web-platform-tests.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA

Closes https://github.com/w3c/pointerevents/issues/167

Bug:  827271 
Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5
Reviewed-on: https://chromium-review.googlesource.com/986877
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550683}
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_support.js
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/mouse_event.h
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/pointer_event.cc
[modify] https://crrev.com/86738ed0dece9f590ed93e7e0a58259bfa0c019c/third_party/blink/renderer/core/events/pointer_event.h

Comment 5 by mustaq@chromium.org, Apr 24 2018

Labels: M-68

►

Issue 827271 link

Issue metadata

PointerEvent.fromElement and .toElement should be null

Issue description

Comment 1 by mustaq@chromium.org, Apr 11 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

Comment 2 Deleted

Comment 3 by mustaq@chromium.org, Apr 13 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Comment 4 Deleted

Comment 5 by mustaq@chromium.org, Apr 24 2018

Comment 5 Deleted

Sign in to add a comment