u2f_register and u2f_sign unittests should verify the bytes of device commands they send out |
||||||
Issue descriptionCurrently, we have EXPECT_CALL(..., DeviceTransact(::testing::_)), which is not great.
,
Mar 31 2018
Remove owner for "available" bug. Feel free to claim it and set it to "assigned" or "started" if you already have a CL in the making.
,
Mar 31 2018
,
Apr 2 2018
Also, as pointed out in crrev.com/c/982632, we should have a unittest for essentially each kind of malformed U2F response, including that which has an EC public key in an invalid format.
,
Apr 3 2018
,
Apr 4 2018
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22af8b37b181fb6db59291dd0063d311e2c47e1a commit 22af8b37b181fb6db59291dd0063d311e2c47e1a Author: Jun Choi <hongjunchoi@chromium.org> Date: Mon Apr 09 04:29:18 2018 Check outgoing U2F request command in unittests Change all test data used in u2f_{register, sign}_unittest.cc to data specified in the CTAP specification. Also, explicitly check the first argument to MockFidoDevice::DeviceTransactPtr(). Bug: 827263 Change-Id: Id82934413d8058afe0c7c356bc562b75d72d05a0 Reviewed-on: https://chromium-review.googlesource.com/994346 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549106} [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/fido_request_handler_unittest.cc [delete] https://crrev.com/038d0bb1c744460122e07651eaf0f9ee670f7682/device/fido/fido_response_test_data.h [add] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/fido_test_data.h [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/get_assertion_handler_unittest.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/get_assertion_task_unittest.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/make_credential_handler_unittest.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/make_credential_task_unittest.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/mock_fido_device.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/u2f_register_unittest.cc [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/u2f_request.h [modify] https://crrev.com/22af8b37b181fb6db59291dd0063d311e2c47e1a/device/fido/u2f_sign_unittest.cc
,
Apr 9 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hongjunchoi@chromium.org
, Mar 29 2018