New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 827261 link

Starred by 1 user
Status: Fixed
Owner:
adithyas@chromium.org
Closed: Apr 2018
Cc:
█ shenghua...@chromium.org
█ offenwanger@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

mac_optional_gpu_tests_rel CQ Build Flake

Project Member Reported by offenwanger@chromium.org, Mar 29 2018 
I'm having a mac_optional_gpu_tests_rel bot fail on the build step with: 

Undefined symbols for architecture x86_64:
 "blink::SVGFilterPrimitiveStandardAttributes::LayoutObjectIsNeeded(blink::ComputedStyle const&)"

It's not my patch because I'm not the only one getting it. 

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/834
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/693

Comment 1 by shenghua...@chromium.org, Mar 31 2018

Components: -Infra>Client>Chrome Blink
Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)
First failed build on this bot is 2018-03-27 11:31 AM (PDT) https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/639

The compile issue was caused by the cl https://chromium-review.googlesource.com/c/chromium/src/+/980591.

Assign to the author, this cl needs to be either reverted or fixed.

Comment 2 by junov@chromium.org, Apr 3 2018

Components: -Blink Blink>SVG

Comment 3 by schenney@chromium.org, Apr 3 2018

Cc: offenwanger@chromium.org shenghua...@chromium.org
Components: -Internals>GPU
The code is right but the build system did not detect the dependency of SVGFEDropFilterElement on SVGFilterPrimitivesStandardAttributes and rebuild the former.

SVGFilterPrimitivesStandardAttributes.h is included in SVGFEDropFilterElement.h.

But, the constructor for SVGFEDropFilterElement is inlined for some reason, which maybe causes the problem.

Anyway, this is a build system issue and probably Mac specific at that. Is it continuing to happen or has it now stopped failing as everything gets re-compiled for other reasons?

Comment 4 by adithyas@chromium.org, Apr 3 2018 

It looks like the failures have stopped. I had a similar issue with another builder as well but it was a different file that didn't get built (see https://bugs.chromium.org/p/chromium/issues/detail?id=826516), so I don't think this is platform specific, but is a problem with the build system.

Comment 5 by adithyas@chromium.org, Apr 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment