Long press on overview button does not properly with windows with transient bubbles. |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Open chrome with a transient child bubble. (crash chrome or something similar) (2) Open a secondary app. (3) Click on transient bubble. (4) Long press overview button. What is the expected result? Chrome gets snapped left What happens instead? Chrome remains unsnapped. "App is not avaliable for split screen" toast shows up
,
Mar 29 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eab353c321d39c1d7c5743e5df8e63588767bb8 commit 5eab353c321d39c1d7c5743e5df8e63588767bb8 Author: Sammie Quon <sammiequon@google.com> Date: Thu Apr 05 00:04:24 2018 splitview: Make overview long press work with transient windows. Enters splitview when focus is on transient child. Use MruWindowListForCycle instead of MruWindowList because the latter counts transient child as well, which would give a wrong limit when checking the minimum amount of windows to open splitview. Test: ash_unittests SplitViewControllerTest.* Bug: 827245 Change-Id: Ibe7985fa52f5d4a03b033311540c8385d01b53ee Reviewed-on: https://chromium-review.googlesource.com/985901 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548261} [modify] https://crrev.com/5eab353c321d39c1d7c5743e5df8e63588767bb8/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/5eab353c321d39c1d7c5743e5df8e63588767bb8/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/5eab353c321d39c1d7c5743e5df8e63588767bb8/ash/wm/splitview/split_view_controller_unittest.cc
,
Apr 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sammiequon@chromium.org
, Mar 29 2018