dependency missing (gn/ninja failed to rebuild all affected files) |
|||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Builder%20%28dbg%29/143677 build failed after https://chromium-review.googlesource.com/c/chromium/src/+/983962 chrome/browser/ui/passwords/manage_passwords_ui_controller.h chrome/browser/ui/passwords/passwords_model_delegate.h did not cause ./chrome/browser/password_manager/password_manager_test_base.cc to recompile in test_support_ui. but chrome/browser/password_manager/password_manager_test_base.cc includes manage_passwords_ui_controller.h that includes chrome/browser/ui/passwords/passwords_model_delegate.h
,
Aug 24
I imagine this issue is no longer happening? Close?
,
Aug 25
I raised this issue on Sheriff duty, because it popped up as a failure that I saw and could not explain, but it closed the tree. I'm not sure what component is appropriate, but someone should actually take the time to reproduce/fully explain it. I don't know what component it should go for triage, but if we don't stamp out the identifiable reasons for closing the tree as they crop up we just slowly get a bad developer experience. Vasilli mentioned "not really referenced" perhaps he has a better handle on whether another instance of this is likely to crop up?
,
Aug 27
At this point the logs are gone and everything compiles. I don't know what to investigate. |
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted