Issue metadata
Sign in to add a comment
|
Position Sticky Breaking Links
Reported by
jeffcrai...@gmail.com,
Mar 29 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Example URL: http://www.ahltracker.com/skaters Steps to reproduce the problem: 1. Hover over table headings to confirm they are links (for sorting table columns) 2. Scroll down on the table window so that position: sticky is activated for the headings 3. Try to hover over the links with position: sticky activated and note that they are no longer working What is the expected behavior? The table header should allow you to click the links on the table headers to sort the columns no matter where the stickied table header is. Right now it only works when position: sticky is not engaged and the table heading is at the very top. What went wrong? I think the hitboxes for the links are not sticking with the table row. The row stays where it should on scroll but the <thead> is disappearing from view which could be the same with the link tags. This isn't a problem in the newest versions of Firefox and Safari, the links remain with the table headings. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 65 Does this work in other browsers? Yes Chrome version: 65.0.3325.181 Channel: stable OS Version: OS X 10.13.3 Flash Version: 26.0.0.131
,
Mar 29 2018
This doesn't happen on Linux (Chrome 66), but I do see it on OSX (Chrome 66 too). It seems to be some kind of scrolling or overlay issue. If I carefully locate the mouse pointer just below "Name", but just above the row, the mouse pointer changes and I can change the sort order, sometimes. Moving the mouse around the page can sometimes bring it back too.
,
Mar 30 2018
Unable to reproduce this issue on reported version 65.0.3325.151 and latest beta 66.0.3359.66 . Same behavior is seen in Firefox as well. Attaching screencast for reference. @Reporter: Please check the video and let us know if we miss anything. Also could you please explain exactly what is the expected behavior and what is missing through a video. This would help in further triaging of the issue. Thanks!
,
Mar 30 2018
Sindhu -- try hovering over one of the header cells when the table has been scrolled down many rows. In the video, it appears that you scrolled back up before hovering over the header cells. Don't scroll back up, just move the mouse over the header cells. Expected: the cursor should change when you hover over the header cells. clicking the header cell should sort the table by that column Actual: cursor stays as pointer. clicking does nothing.
,
Mar 31 2018
Attached a video of what's happening. Once you scroll the hit boxes for the links disappear. Just tried it on Firefox and if you recreate in Firefox what I did in the video the sort column links still work.
,
Apr 2 2018
Able to reproduce the issue on reported version 65.0.3325.181, on latest beta# 66.0.3359.66 and on latest canary 67.0.3386.0 using Windows 10 & Mac 10.13.3 Pro. NOTE: Issue is not seen in Ubuntu 14.04 and MacBook Air 10.13.3 Bisect Info: ============= Good Build: 65.0.3312.0 Bad Build: 65.0.3313.0 You are probably looking for a change made after 527379 (known good), but no later than 527380 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/c8f9ef323c67d6207df5ec0383503653a41ee113..ed23c5622a815ec34ef4160db567cf83bccfcc41 Reviewed-on: https://chromium-review.googlesource.com/849417 @ chrishtr: Please confirm the issue and help in re-assigning if it is not related to your change, Adding ReleaseBlock-Stable for M-65 as it seems recent break, feel free to remove it if not applicable. Thanks!
,
Apr 2 2018
,
Apr 2 2018
,
Apr 2 2018
,
Apr 2 2018
,
Apr 2 2018
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks!
,
Apr 3 2018
,
Apr 4 2018
The bug is that sticky position constraints are not being re-computed and updated in the property trees after a composited scroll, resulting in an incorrect offset during clip computation for hit testing.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b087bb812734db76b31de8c6e2efd62d1b0a15a7 commit b087bb812734db76b31de8c6e2efd62d1b0a15a7 Author: Chris Harrelson <chrishtr@chromium.org> Date: Wed Apr 04 17:43:43 2018 [PE] Invalidate sticky constraints on composited scroll. This ensures that property tree state for the sticky elements are updated properly, to subsequently be used in hit testing and paint. Bug:827224 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If6fbfbe49b6b08046d40ecb2da636ee1f22cb486 Reviewed-on: https://chromium-review.googlesource.com/994462 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548120} [modify] https://crrev.com/b087bb812734db76b31de8c6e2efd62d1b0a15a7/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/b087bb812734db76b31de8c6e2efd62d1b0a15a7/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
,
Apr 4 2018
,
Apr 4 2018
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2018
Approving merge to M66. Branch:3359
,
Apr 5 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06610171a6af967d293929b5293afa4bf870f290 commit 06610171a6af967d293929b5293afa4bf870f290 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Apr 05 20:38:21 2018 [PE] Invalidate sticky constraints on composited scroll. This ensures that property tree state for the sticky elements are updated properly, to subsequently be used in hit testing and paint. Bug:827224 TBR=chrishtr@chromium.org (cherry picked from commit b087bb812734db76b31de8c6e2efd62d1b0a15a7) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If6fbfbe49b6b08046d40ecb2da636ee1f22cb486 Reviewed-on: https://chromium-review.googlesource.com/994462 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#548120} Reviewed-on: https://chromium-review.googlesource.com/998743 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#595} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/06610171a6af967d293929b5293afa4bf870f290/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/06610171a6af967d293929b5293afa4bf870f290/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
,
Apr 5 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72cbcc5024654e9b1f32626001f7b12a4b3b851c commit 72cbcc5024654e9b1f32626001f7b12a4b3b851c Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Date: Fri Apr 06 09:48:04 2018 Revert "[PE] Invalidate sticky constraints on composited scroll." This reverts commit 06610171a6af967d293929b5293afa4bf870f290. Reason for revert: HasStickyDescendants() does not exist on the Beta branch. Bug:827224,829704 Original change's description: > [PE] Invalidate sticky constraints on composited scroll. > > This ensures that property tree state for the sticky elements are updated > properly, to subsequently be used in hit testing and paint. > > Bug:827224 > > TBR=chrishtr@chromium.org > > (cherry picked from commit b087bb812734db76b31de8c6e2efd62d1b0a15a7) > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: If6fbfbe49b6b08046d40ecb2da636ee1f22cb486 > Reviewed-on: https://chromium-review.googlesource.com/994462 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#548120} > Reviewed-on: https://chromium-review.googlesource.com/998743 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/branch-heads/3359@{#595} > Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: I3886359539c0d6768d1e882cf992345ce74c315f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827224 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/998894 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#603} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/72cbcc5024654e9b1f32626001f7b12a4b3b851c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/72cbcc5024654e9b1f32626001f7b12a4b3b851c/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c414ffb9a2f7b0d8d1d17bcfd635d9ce8204a093 commit c414ffb9a2f7b0d8d1d17bcfd635d9ce8204a093 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Apr 06 17:12:10 2018 Reland "[PE] Invalidate sticky constraints on composited scroll." This reverts commit 72cbcc5024654e9b1f32626001f7b12a4b3b851c. Reason for revert: An ealier commit (96e0ffd97ab663f9f3271a7fc8eb8b7d17d23562) fixed the compile failure. Original change's description: > Revert "[PE] Invalidate sticky constraints on composited scroll." > > This reverts commit 06610171a6af967d293929b5293afa4bf870f290. > > Reason for revert: HasStickyDescendants() does not exist on the Beta branch. > > Bug:827224,829704 > > Original change's description: > > [PE] Invalidate sticky constraints on composited scroll. > > > > This ensures that property tree state for the sticky elements are updated > > properly, to subsequently be used in hit testing and paint. > > > > Bug:827224 > > > > TBR=chrishtr@chromium.org > > > > (cherry picked from commit b087bb812734db76b31de8c6e2efd62d1b0a15a7) > > > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: If6fbfbe49b6b08046d40ecb2da636ee1f22cb486 > > Reviewed-on: https://chromium-review.googlesource.com/994462 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#548120} > > Reviewed-on: https://chromium-review.googlesource.com/998743 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Cr-Commit-Position: refs/branch-heads/3359@{#595} > > Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} > > TBR=wangxianzhu@chromium.org,chrishtr@chromium.org > > Change-Id: I3886359539c0d6768d1e882cf992345ce74c315f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 827224 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/998894 > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/branch-heads/3359@{#603} > Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org,mvanouwerkerk@chromium.org Change-Id: Ib678ca68de0d8f2e818c04eacba192ac6f3946b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827224 , 829704 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/999336 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#605} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/c414ffb9a2f7b0d8d1d17bcfd635d9ce8204a093/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/c414ffb9a2f7b0d8d1d17bcfd635d9ce8204a093/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
,
Apr 23 2018
Issue 835307 has been merged into this issue.
,
Apr 30 2018
Issue 838107 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by viswa.karala@chromium.org
, Mar 29 2018