Issue metadata
Sign in to add a comment
|
Enable thinlto on arm. |
||||||||||||||||||||||
Issue descriptionWe have enabled ThinLTO to build chrome on all the AMD64 release builds. We want to enable it on ARM too.
,
Mar 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4abff33323406f30263066f841399d30521e1d9a commit 4abff33323406f30263066f841399d30521e1d9a Author: Yunlian Jiang <yunlian@chromium.org> Date: Sat Mar 31 02:46:52 2018 chromeos_config: Remove USE=thinlto from release builders. We have landed CL:986656 to enable thinlto on AMD64 release builders. So there is no need to add this flag to all the release builders as we disabled this use flag on arm already. BUG= chromium:827217 TEST=run_tests, USE=thinlto is kept in AMD64 builders. Change-Id: If001f234d3b2a01e9b49993b66a12ecbeb39e380 Reviewed-on: https://chromium-review.googlesource.com/988068 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/4abff33323406f30263066f841399d30521e1d9a/cbuildbot/config_dump.json [modify] https://crrev.com/4abff33323406f30263066f841399d30521e1d9a/cbuildbot/chromeos_config.py
,
Mar 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/af2ba0cbabe8a6a29e68a75d1413dc3844f01fa2 commit af2ba0cbabe8a6a29e68a75d1413dc3844f01fa2 Author: Yunlian Jiang <yunlian@chromium.org> Date: Sat Mar 31 02:46:50 2018 chromeos-chrome: enable debug fission for ARM on thinlto build. ThinLTO implicitly disables debug fission. Without debug fission, we could not build chrome for ARM32 because the unstripped binary execeeds 4GB limit. The flag -glto-dwo-dir=DIR will put the separated .dwo files in the specified directory during ThinLTO link stage and makes chrome builds with thinlto on ARM. BUG= chromium:827217 TEST=USE=thinlto emerge-kevin chromeos-chrome builds. Change-Id: I5e31dd547cd522739884309c2ad0dc00ed0b0cc9 Reviewed-on: https://chromium-review.googlesource.com/988747 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/af2ba0cbabe8a6a29e68a75d1413dc3844f01fa2/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Mar 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e11a8910b46299ad2bd6d3860016a3dd4b5043f9 commit e11a8910b46299ad2bd6d3860016a3dd4b5043f9 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Mar 31 04:01:58 2018 Roll src/third_party/chromite/ 907239157..c7cb8ed2a (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/907239157e6a..c7cb8ed2a1ec $ git log 907239157..c7cb8ed2a --date=short --no-merges --format='%ad %ae %s' 2018-03-28 ayatane Rename venv_python script 2018-03-30 yunlian chromeos_config: Remove USE=thinlto from release builders. 2018-03-30 shapiroc CBuildBot support for YAML file 2018-03-25 jclinton cbuildbot/stages/build_stages: Make model probe at end silent Created with: roll-dep src/third_party/chromite BUG=chromium:810460, chromium:827217 ,chromium:none The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifa38cba737199e75e2a1319150248a9bc1b31166 Reviewed-on: https://chromium-review.googlesource.com/989304 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547372} [modify] https://crrev.com/e11a8910b46299ad2bd6d3860016a3dd4b5043f9/DEPS
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b4f39f61330c8455880daee3750977225211efbb commit b4f39f61330c8455880daee3750977225211efbb Author: Yunlian Jiang <yunlian@chromium.org> Date: Tue Apr 03 23:12:42 2018 llvm: apply a patch to support debug fission with thinlto. This CL cherry picks two pending upstream CLs https://reviews.llvm.org/D44792 https://reviews.llvm.org/D44788 So that we can build chrome with thinlto for arm boards. This CL does not change the codegen without the option -glto-dow-dir= BUG= chromium:827217 TEST=sudo emerge llvm; sudo USE=llvm-next emerge llvm. Change-Id: I234750817df4a87512f6759b43e40c6f2f410a7f Reviewed-on: https://chromium-review.googlesource.com/988144 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [rename] https://crrev.com/b4f39f61330c8455880daee3750977225211efbb/sys-devel/llvm/llvm-7.0_pre326829_p20180318-r7.ebuild [add] https://crrev.com/b4f39f61330c8455880daee3750977225211efbb/sys-devel/llvm/files/llvm-7.0-flto-fission.patch
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/12074a929aa52fed259a270e7768f485ee6d2af5 commit 12074a929aa52fed259a270e7768f485ee6d2af5 Author: Yunlian Jiang <yunlian@chromium.org> Date: Mon Apr 09 22:18:56 2018 chromeos-chrome: fix a typo in ebuild. CL:988747 has a typo on append-ldflags. This CL fixes that. BUG= chromium:827217 TEST=USE=thinlto emerge-kevin chromeos-chrome builds Change-Id: I369de351e35a4ce6cd6d47c5dc3e789a80472661 Reviewed-on: https://chromium-review.googlesource.com/1002920 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/12074a929aa52fed259a270e7768f485ee6d2af5/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/74d7d171a121135f3a16daba6485e63e2fe6cc9f commit 74d7d171a121135f3a16daba6485e63e2fe6cc9f Author: Yunlian Jiang <yunlian@google.com> Date: Thu Apr 26 20:01:45 2018 chromeos_config: only set USE=thinlto for amd64 toolchain builders. Previously we added USE=thinlto for all the release builders in cbuildbot and masked USE=thinlto for ARM boards so that only AMD64 buidlers have USE=thinlto when building Chrome. Now we want to test a few ARM boards with thinlto. This CL removes 'thinlto' from the default useflags of ToolchainBuilders. It also adds the 'thinlto' use flag back to the AMD64 toolchain builders. BUG= chromium:827217 TEST=the updated config_dump.json still contains USE="thinlto" for toolchain builders of AMD64 boards. run_tests passes. Change-Id: I48c71b86fb2c9e7e685de3c299204747981fbfb9 Reviewed-on: https://chromium-review.googlesource.com/986621 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/74d7d171a121135f3a16daba6485e63e2fe6cc9f/cbuildbot/config_dump.json [modify] https://crrev.com/74d7d171a121135f3a16daba6485e63e2fe6cc9f/cbuildbot/chromeos_config.py
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0f8b9869b23d356c72b1dd71b4cad1cd5d51b739 commit 0f8b9869b23d356c72b1dd71b4cad1cd5d51b739 Author: Yunlian Jiang <yunlian@chromium.org> Date: Thu Apr 26 20:48:00 2018 Remove use mask USE="thinlto" from chromeos-chrome on ARM In order to enable ThinLTO to build Chrome on ARM platform, we need to remove this mask first. This CL has no affect on release builders. But it will enable ThinLTO on all toolchain builders. CQ-DEPEND=CL:988144 BUG= chromium:827217 TEST=cros tryjob kevin-release kevin-llvm-toolchain Change-Id: I5919eb4b1f996b2603b3ffb20a739abd57bb59c8 Reviewed-on: https://chromium-review.googlesource.com/993172 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/0f8b9869b23d356c72b1dd71b4cad1cd5d51b739/profiles/arch/arm/package.use.mask
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942fac472373af6a535d5bf7d93343cdd3964ff9 commit 942fac472373af6a535d5bf7d93343cdd3964ff9 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 26 23:46:55 2018 Roll src/third_party/chromite/ aa6cca469..74d7d171a (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/aa6cca46950b..74d7d171a121 $ git log aa6cca469..74d7d171a --date=short --no-merges --format='%ad %ae %s' 2018-04-25 yunlian chromeos_config: only set USE=thinlto for amd64 toolchain builders. 2018-04-12 bmgordon cbuildbot_launch: Track state of the previous build 2018-04-23 levarum Copy ndk-translation artifacts when uprevving android Created with: roll-dep src/third_party/chromite BUG= chromium:827217 , chromium:829665 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ida506a20c73f9feffdc2c0aac80d5eb872ae115d Reviewed-on: https://chromium-review.googlesource.com/1031170 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554191} [modify] https://crrev.com/942fac472373af6a535d5bf7d93343cdd3964ff9/DEPS
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b7c091c4f4f0a00868376abc88a07e040a197841 commit b7c091c4f4f0a00868376abc88a07e040a197841 Author: Yunlian Jiang <yunlian@google.com> Date: Sat May 12 06:22:29 2018 enable thinlto on elm and veryon_jaq release builders. We want to enable thinlto on two ARM boards for now. If everything goes well, we will enable thinlto on all ARM boards with different configurations. BUG= chromium:827217 TEST=cros tryjob elm-rlease veyron_jaq release Change-Id: I4f13174d3035e6bd58c5f997ff529edd2d270d60 Reviewed-on: https://chromium-review.googlesource.com/1053223 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [modify] https://crrev.com/b7c091c4f4f0a00868376abc88a07e040a197841/cbuildbot/config_dump.json [modify] https://crrev.com/b7c091c4f4f0a00868376abc88a07e040a197841/cbuildbot/chromeos_config.py
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b56c82da073859094b43650e13a6b016e59a2ca commit 3b56c82da073859094b43650e13a6b016e59a2ca Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat May 12 07:40:38 2018 Roll src/third_party/chromite/ 348b95b14..50c42dd35 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/348b95b14ab7..50c42dd35113 $ git log 348b95b14..50c42dd35 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 khmel arc: Fix ACL for archive with SDK tools 2018-05-09 yunlian enable thinlto on elm and veryon_jaq release builders. Created with: roll-dep src/third_party/chromite BUG= chromium:827217 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id75b97be2c132d6fcdfa128b050efc5d1d55fc35 Reviewed-on: https://chromium-review.googlesource.com/1056474 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558125} [modify] https://crrev.com/3b56c82da073859094b43650e13a6b016e59a2ca/DEPS
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/87fad79e099deeaef4ddf1d32fde1e96fa81fc28 commit 87fad79e099deeaef4ddf1d32fde1e96fa81fc28 Author: Yunlian Jiang <yunlian@google.com> Date: Fri Jun 08 06:33:59 2018 chromeos-chrome: change inline parameter for thinlto on arm from 30 to 20 This changes the inline paramter for thinlto on arm to reduce the text size increase. vanilla thinlto thinlto_with_this change. binary size 94863440 106457936 101153504 text size 91182142 102891665 97582889 performance data is at https://goto.google.com/chromeos_arm_thinlto_tune Performance summary: No difference for jetstream, kraken, page_cycler_typical_25, graphics_WebGLAquarium, speedometer, speedometer2, octane. No statistically significant difference on video_PlaybackPerf.h264, video_PlaybackPerf.vp9, video_WebRtcPerf cros_ui_smoothness has some degradation, the p-value is 0.16. BUG= chromium:827217 TEST=cros tryjob peach-pit-chrome-pfq verify size and performance. Change-Id: Iab7e6779cf35f44050761ca342d7897b8ad63b06 Reviewed-on: https://chromium-review.googlesource.com/1091111 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/87fad79e099deeaef4ddf1d32fde1e96fa81fc28/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b6b03e9d0f7d6077726f88c4ae871a0dc3278722 commit b6b03e9d0f7d6077726f88c4ae871a0dc3278722 Author: Yunlian Jiang <yunlian@google.com> Date: Sat Jun 09 09:19:22 2018 llvm: put .dwo files into different directories. https://reviews.llvm.org/D44788 has a newer version. With new version, it stores the .dwo files for one binary in a dedicated directory to avoid file conflict. This CL modify the patch accordingly. BUG= chromium:827217 TEST=cros tryjob elm-llvm-toolchain-tryjob Change-Id: I93d49fd16d35dfeca73574d8fd0b659eca9a0af4 Reviewed-on: https://chromium-review.googlesource.com/1091974 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/b6b03e9d0f7d6077726f88c4ae871a0dc3278722/sys-devel/llvm/files/clang-7.0-flto-fission.patch [rename] https://crrev.com/b6b03e9d0f7d6077726f88c4ae871a0dc3278722/sys-devel/llvm/llvm-7.0_pre331547_p20180529-r1.ebuild
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e1abb59787bb008fc6ed55cd8e6a2ef0a0a6f2ab commit e1abb59787bb008fc6ed55cd8e6a2ef0a0a6f2ab Author: Yunlian Jiang <yunlian@google.com> Date: Mon Jun 11 18:40:40 2018 Enable ThinLTO on all ARM boards. We have enabled ThinLTO on elm and peach_pit in R68 and so far so good. This CL enables ThinLTO on all ARM boards. BUG= chromium:827217 TEST=cros tryjob {daisy, nyan_bing, veyron_minnie,kevin}-llvm-toolchain-tryjob Change-Id: I703d1d1cff2dc474674f4cc425bac318508be301 Reviewed-on: https://chromium-review.googlesource.com/1095415 Reviewed-by: Yunlian Jiang <yunlian@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Trybot-Ready: Yunlian Jiang <yunlian@chromium.org> [add] https://crrev.com/e1abb59787bb008fc6ed55cd8e6a2ef0a0a6f2ab/profiles/arch/arm/package.use
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ff7c2f50aefe670df083662c8d0f5d2a1b5909b7 commit ff7c2f50aefe670df083662c8d0f5d2a1b5909b7 Author: Yunlian Jiang <yunlian@google.com> Date: Tue Jun 19 10:48:56 2018 chromeos-chrome: enable thinlto for all boards. This sets the USE flag 'thinlto' to true to enable thinlto on all the boards. We have enabled this feature on both AMD and ARM boards. This CL is just a clean up. BUG= chromium:827217 TEST=cros tryjob {daisy, nyan_bing, veyron_minnie,kevin}-llvm-toolchain-tryjob Change-Id: I26de2b3b673f2a0a3318ab4f58d99b56ed57ea42 Reviewed-on: https://chromium-review.googlesource.com/1091159 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/ff7c2f50aefe670df083662c8d0f5d2a1b5909b7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9d5371ac95b1e65b7b11a2faeb5f71e70e2d86ff commit 9d5371ac95b1e65b7b11a2faeb5f71e70e2d86ff Author: Yunlian Jiang <yunlian@chromium.org> Date: Thu Jun 21 19:18:10 2018 Revert "chromeos-chrome: enable thinlto for all boards." This reverts commit ff7c2f50aefe670df083662c8d0f5d2a1b5909b7. Reason for revert: chromium:854801 Original change's description: > chromeos-chrome: enable thinlto for all boards. > > This sets the USE flag 'thinlto' to true to enable thinlto on all the boards. > We have enabled this feature on both AMD and ARM boards. This CL is just a clean > up. > > BUG= chromium:827217 > TEST=cros tryjob {daisy, nyan_bing, veyron_minnie,kevin}-llvm-toolchain-tryjob > > Change-Id: I26de2b3b673f2a0a3318ab4f58d99b56ed57ea42 > Reviewed-on: https://chromium-review.googlesource.com/1091159 > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > Tested-by: Yunlian Jiang <yunlian@chromium.org> > Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Bug: chromium:827217 Change-Id: Id51fd809e76ddcfcb6db0176181d5b8097f9a940 Reviewed-on: https://chromium-review.googlesource.com/1109277 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/9d5371ac95b1e65b7b11a2faeb5f71e70e2d86ff/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/18d4174e81bf6404f37fdb3f30bbefdeff17b1fa commit 18d4174e81bf6404f37fdb3f30bbefdeff17b1fa Author: Yunlian Jiang <yunlian@google.com> Date: Fri Jun 29 00:52:48 2018 llvm: pick upstream patch to enable debug fission with lto. This picks an upstream patch to add an option to support debeug fission on implicit ThinLTO. BUG= chromium:827217 TEST=sudo emerge llvm. Change-Id: I79b07f929efd9e0e8b1e37c8e11e888e79d8e623 Reviewed-on: https://chromium-review.googlesource.com/1118710 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> [add] https://crrev.com/18d4174e81bf6404f37fdb3f30bbefdeff17b1fa/sys-devel/llvm/files/cherry/3707aa46066aa2da2490fe79c65c6c45c6957ece.patch [add] https://crrev.com/18d4174e81bf6404f37fdb3f30bbefdeff17b1fa/sys-devel/llvm/files/clang-7.0-flto-objcopy.patch [rename] https://crrev.com/18d4174e81bf6404f37fdb3f30bbefdeff17b1fa/sys-devel/llvm/llvm-7.0_pre331547_p20180529-r3.ebuild
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/283590961930b56049a9c767859c0842177101c3 commit 283590961930b56049a9c767859c0842177101c3 Author: Yunlian Jiang <yunlian@google.com> Date: Fri Jun 29 18:51:29 2018 llvm: change the .dwo name with thinlto Privously we set unique names for .dwo files across different builds. This patch makes the .dwo files have the same name across different builds. With this change, we can keep the .dwo files without worrying the size of .dwo files in incremental builds. We can remove this patch after we upgrade llvm to r332884 or newer, since that CL did the same thing. BUG= chromium:827217 TEST=USE="thinlto" emerge-daisy chromeos-chrome Change-Id: I8246eb2f1a6b20a3f5fd60d620d1fb56facc44df Reviewed-on: https://chromium-review.googlesource.com/1120867 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> [rename] https://crrev.com/283590961930b56049a9c767859c0842177101c3/sys-devel/llvm/llvm-7.0_pre331547_p20180529-r4.ebuild [add] https://crrev.com/283590961930b56049a9c767859c0842177101c3/sys-devel/llvm/files/llvm-7.0-dwo-name.patch
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7dd88fc7ddb42f1d9fbb80ae428156eb2e90a23b commit 7dd88fc7ddb42f1d9fbb80ae428156eb2e90a23b Author: Yunlian Jiang <yunlian@google.com> Date: Fri Jun 29 20:29:39 2018 Enable ThinLTO on all ARM boards. We have enabled ThinLTO on elm and peach_pit in R68 and so far so good. This CL enables ThinLTO on all ARM boards. We enabled this feature via CL:1095415 but it got reverted because of chromium:854801. We believe that we have identified the root cause and fixed the problem. BUG= chromium:827217 chromium:854801 TEST=cros tryjob daisy-release Change-Id: I3a440f2faeff7c4ffa5a1117040f20ef21b63af0 Reviewed-on: https://chromium-review.googlesource.com/1120944 Reviewed-by: Yunlian Jiang <yunlian@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> [add] https://crrev.com/7dd88fc7ddb42f1d9fbb80ae428156eb2e90a23b/profiles/arch/arm/package.use
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/89981a8b31aeafb66f3081293389162044f3bcc5 commit 89981a8b31aeafb66f3081293389162044f3bcc5 Author: Yunlian Jiang <yunlian@google.com> Date: Tue Jul 03 18:41:05 2018 chromeos-chrome: remove temporary .dwo file directory CL:1114070 introduced an error that it keeps the .dwo file directory. This directory is not needed, so we need to remove it. BUG= chromium:827217 TEST=the .dwo directory was removed after emerge. Change-Id: I3a4f06b192b2952e446ae4f0d6f4f842599ac25d Reviewed-on: https://chromium-review.googlesource.com/1120638 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/89981a8b31aeafb66f3081293389162044f3bcc5/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jul 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/67b8640b10c566726e56b21c93c173f3eedc0928 commit 67b8640b10c566726e56b21c93c173f3eedc0928 Author: Yunlian Jiang <yunlian@google.com> Date: Sun Jul 08 03:26:49 2018 chromeos-chrome: change the LDFLAGS for thinlto on ARM LLVM upstream has decided to use link flag '-gsplit-dwarf' to enable debug fission on LTO builds, we want to use the same flag. BUG= chromium:827217 TEST=USE="thinlto" emerge-daisy chromeos-chrome Change-Id: I3f0a65dbff519e734d291c6f6717fa7171fafb8c Reviewed-on: https://chromium-review.googlesource.com/1128368 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/67b8640b10c566726e56b21c93c173f3eedc0928/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jul 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/56f60dcb714ba550adad6fd686be9f3e9e963595 commit 56f60dcb714ba550adad6fd686be9f3e9e963595 Author: Yunlian Jiang <yunlian@google.com> Date: Sat Jul 21 01:34:09 2018 chromeos-chrome: enable USE=thinlto We have enabled USE=thinlto on both ARM and AMD64 boards by modifying the profiles. Now we can enable USE=thinlto in the ebuild files for now. This CL does not have any affect, it is just a clean up. BUG= chromium:827217 TEST=none Change-Id: If2c9911458739fe619d3f30c0cf836fa23d70e75 Reviewed-on: https://chromium-review.googlesource.com/1144044 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/56f60dcb714ba550adad6fd686be9f3e9e963595/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 31
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 30 2018