New issue
Advanced search Search tips

Issue 827212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Use of WifiManager in AndroidNetworkLibrary should be guarded behind location permissions

Project Member Reported by tbansal@chromium.org, Mar 29 2018

Issue description

I took a look at this and it looked like data-reduction-proxy and network-quality-estimator were the main callers of this API.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed90e4518191399b71b14c9dff648a45c16491e6

commit ed90e4518191399b71b14c9dff648a45c16491e6
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Apr 06 03:07:17 2018

Update AndroidNetworkLibrary getSSID function to handle lack of permissions.

getSSID on Android may return a special pre-defined string if the app
does not have permissions to get the SSID.

In that case, the method returns an empty string.

Change-Id: I58c99301b4d611124c8434e93fd787edbec32da3
Bug:  827212 
Reviewed-on: https://chromium-review.googlesource.com/987306
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548650}
[modify] https://crrev.com/ed90e4518191399b71b14c9dff648a45c16491e6/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java
[modify] https://crrev.com/ed90e4518191399b71b14c9dff648a45c16491e6/net/android/network_library.h
[modify] https://crrev.com/ed90e4518191399b71b14c9dff648a45c16491e6/net/base/network_interfaces.h

Status: Fixed (was: Started)

Sign in to add a comment