New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827199 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] Shrinking the window to its smallest size is too small

Project Member Reported by meh...@chromium.org, Mar 29 2018

Issue description

Chrome Version: Canary 67.0.3382.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable chrome://flags/#views-browser-windows
(2) Open a window
(3) Shrink it to its smallest size

What is the expected result?
The window is too small.

What happens instead?
Mac applications are always larger at its smallest size.

Screenshots are attached.


 
actual.png
21.4 KB View Download
expected.png
55.5 KB View Download
Labels: M-68 MacViews-Browser Target-68
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
The "actual" screenshot is kind of adorable.

lgrey@, can you take a look? We probably need to enforce the minimum window size.

Comment 2 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d718f7d6d3e8730d729d17702a5cd23de3f2397

commit 9d718f7d6d3e8730d729d17702a5cd23de3f2397
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Apr 10 20:37:08 2018

[MacViews] Clamp minimum browser size to match Cocoa

Constants and logic brought over from chrome/browser/ui/cocoa/browser_window_controller.h

Bug:  827199 
Change-Id: Ida44f197ba2039c060824b1dcf247c889d99b470
Reviewed-on: https://chromium-review.googlesource.com/1005001
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549634}
[modify] https://crrev.com/9d718f7d6d3e8730d729d17702a5cd23de3f2397/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm

Comment 4 by lgrey@chromium.org, Apr 10 2018

Status: Fixed (was: Assigned)
Cc: sindhu.chelamcherla@chromium.org
Labels: TE-Verified-M67 TE-Verified-67.0.3394.0
Able to reproduce this issue on build without fix(67.0.3393.0). Hence verifying the issue on latest canary 67.0.3394.0 on Mac 10.13.3

Observing larger shrinked window size when compared to build without fix. Attaching screenshot for reference. As fix is working as expected adding Verified labels.

Thanks!
827199_67.0.3394.0.png
258 KB View Download

Sign in to add a comment