Supersize: Add source maps for very large .other symbols and res/ dir. |
||||||
Issue descriptionBig one: icudtl.dat, should be in its own place. Smaller ones: res/*, should be mapped to where it came from. Others: Optional
,
Apr 12 2018
res/* and the rest of .other symbols are relatively small. Leaving those under *.apk.
,
Apr 12 2018
Let's re-open for res/. There is potential for much more res/ to be added, and currently it's actually not that small (~1.3mb). Adding source paths should be fairly straight-foward to do in the same way we did pak (each prepare_resources.py invocation can write a .info file). I agree it's not high priority though.
,
Apr 16 2018
Sounds good, updated summary to reflect what we want to do.
,
Apr 16 2018
I would like to actually do this earlier since we want to stable mappings earlier to compare between milestones.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da8025abca3ac835c8f59f4622372d4dec02fcae commit da8025abca3ac835c8f59f4622372d4dec02fcae Author: Peter Wen <wnwen@chromium.org> Date: Thu Apr 19 17:57:10 2018 Supersize: Properly attribute res/ symbols Create .info files for resources during jinja processing, aapt2 compressing, and aapt2 linking, using these .info files to create a per-apk *.apk.res.info file that supersize then uses to properly map a resource file back to its source file. There is some complexity with resource overloading and android build tools changing the resource file or directory as part of packaging an apk. This is handled by a combination of storing renames and parsing heuristics. Bug: 827196 Change-Id: Ic8243c218791ec048b1563604d93c7b735fdc71c Reviewed-on: https://chromium-review.googlesource.com/1014255 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#552081} [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/apkbuilder.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/compile_resources.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/generate_v14_compatible_resources.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/jinja_template.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/prepare_resources.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/android/gyp/util/resource_utils.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/build/config/android/internal_rules.gni [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/apkanalyzer.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/archive.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/integration_test.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/models.py [modify] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/testdata/Archive_Apk.golden [add] https://crrev.com/da8025abca3ac835c8f59f4622372d4dec02fcae/tools/binary_size/libsupersize/testdata/mock_output_directory/size-info/test.apk.res.info
,
Apr 19 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 11 2018