New issue
Advanced search Search tips

Issue 827191 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebrtcLoggingPrivateApiTest problems

Project Member Reported by eladalon@chromium.org, Mar 29 2018

Issue description

WebrtcLoggingPrivateApiTest.StartEventLoggingForKnownPeerConnection and WebrtcLoggingPrivateApiTest.StartEventLoggingForUnknownPeerConnection are not providing good coverage, because the functions they are testing do not emit an error, meaning RunFunctionAndReturnSingleResult() would not catch if they unexpectedly fail.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f

commit 4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f
Author: Elad Alon <eladalon@chromium.org>
Date: Mon Apr 09 15:48:27 2018

Add error reporting to logging.startEventLogging

Error-specific messages are produced for:
* Feature not available.
* Bad parameters (max size too small, too big, etc.)
* Bad state (already logging, unknown peer connection, etc.)

A generic error is produced for:
* Incognito mode.
* File system errors.
* Too many pending logs.
* Too many active logs.

The purpose of using generic errors, is to not expose sensitive
information, neither explicitly (specific-error) nor implicitly,
which would be the case if, for example, only incognito mode
could produce the generic error.

Bug: 775415,  827191 
Change-Id: I10c12d1a0fc7ad4476511fc5d6383c1cd5e9d512
Reviewed-on: https://chromium-review.googlesource.com/986575
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549187}
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager_common.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager_common.h
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/4c7bab6f7238bf95e4f601acbdb9e37efe2b2f7f/chrome/browser/media/webrtc/webrtc_logging_handler_host.cc

Status: Fixed (was: Assigned)

Sign in to add a comment