New issue
Advanced search Search tips

Issue 827181 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

interactive_ui_tests fail on Mac10.13 Tests (dbg) due to extensions::ExtensionRegistryFactory::GetBrowserContextToUse

Project Member Reported by fdoray@chromium.org, Mar 29 2018

Issue description

All interactive_ui_tests are failing with this error on  Mac10.13 Tests (dbg) since build 877:

[ RUN      ] ExtensionCrashRecoveryTest.ShutdownWhileCrashed
[2871:4611:0328/171848.660071:WARNING:notification_platform_bridge_mac.mm(511)] AlertNotificationService: XPC connection invalidated.
2018-03-28 17:18:48.876 interactive_ui_tests[2871:2981470] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
[2876:775:0328/171848.893462:WARNING:vt_video_decode_accelerator_mac.cc(177)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973)
[2876:775:0328/171848.894203:WARNING:vt_video_decode_accelerator_mac.cc(199)] Failed to create hardware VideoToolbox session
Received signal 11 SEGV_MAPERR 000000000000
[2876:775:0328/171848.959286:ERROR:vt_video_encode_accelerator_mac.cc(517)]  VTCompressionSessionCreate failed: -12908
0   libbase.dylib                       0x00000001293c753e base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x00000001293c75fd base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x00000001293c5aac base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x00000001293c732f base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 1407
4   libsystem_platform.dylib            0x00007fff609d3f5a _sigtramp + 26
5   ???                                 0x00007ffee46ed4e8 0x0 + 140732730889448
6   interactive_ui_tests                0x000000010c58343a extensions::ExtensionRegistryFactory::GetBrowserContextToUse(content::BrowserContext*) const + 42
7   libkeyed_service_content.dylib      0x0000000142532083 BrowserContextKeyedServiceFactory::GetContextToUse(base::SupportsUserData*) const + 67
8   libkeyed_service_core.dylib         0x0000000140df7af5 KeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 341
9   libkeyed_service_content.dylib      0x0000000142531ce7 BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) + 55
10  interactive_ui_tests                0x000000010c583292 extensions::ExtensionRegistryFactory::GetForBrowserContext(content::BrowserContext*) + 34
11  interactive_ui_tests                0x000000010c57d3c5 extensions::ExtensionRegistry::Get(content::BrowserContext*) + 21
12  interactive_ui_tests                0x0000000112e86ff3 extensions::ChromeContentBrowserClientExtensionsPart::SiteInstanceGotProcess(content::SiteInstance*) + 83
13  interactive_ui_tests                0x000000010e85691e ChromeContentBrowserClient::SiteInstanceGotProcess(content::SiteInstance*) + 526
14  libcontent.dylib                    0x000000012e349288 content::SiteInstanceImpl::GetProcess() + 936
15  libcontent.dylib                    0x000000012e442f7f content::WebContentsImpl::Init(content::WebContents::CreateParams const&) + 495
16  libcontent.dylib                    0x000000012e42a344 content::WebContentsImpl::CreateWithOpener(content::WebContents::CreateParams const&, content::RenderFrameHostImpl*) + 1060
17  libcontent.dylib                    0x000000012e429f0c content::WebContents::Create(content::WebContents::CreateParams const&) + 44
18  interactive_ui_tests                0x00000001144aea9f (anonymous namespace)::CreateTargetContents(NavigateParams const&, GURL const&) + 479
19  interactive_ui_tests                0x00000001144abad0 Navigate(NavigateParams*) + 2400
20  interactive_ui_tests                0x000000011455af14 StartupBrowserCreatorImpl::OpenTabsInBrowser(Browser*, bool, std::__1::vector<StartupTab, std::__1::allocator<StartupTab> > const&) + 1124
21  interactive_ui_tests                0x000000011455d4cc StartupBrowserCreatorImpl::RestoreOrCreateBrowser(std::__1::vector<StartupTab, std::__1::allocator<StartupTab> > const&, StartupBrowserCreatorImpl::BrowserOpenBehavior, unsigned int, bool, bool) + 1068
22  interactive_ui_tests                0x000000011455a1ff StartupBrowserCreatorImpl::DetermineURLsAndLaunch(bool, std::__1::vector<GURL, std::__1::allocator<GURL> > const&) + 1151
23  interactive_ui_tests                0x0000000114558f15 StartupBrowserCreatorImpl::Launch(Profile*, std::__1::vector<GURL, std::__1::allocator<GURL> > const&, bool) + 1397
24  interactive_ui_tests                0x000000011454f8cb StartupBrowserCreator::LaunchBrowser(base::CommandLine const&, Profile*, base::FilePath const&, chrome::startup::IsProcessStartup, chrome::startup::IsFirstRun) + 715
25  interactive_ui_tests                0x0000000114551e87 StartupBrowserCreator::LaunchBrowserForLastProfiles(base::CommandLine const&, base::FilePath const&, bool, Profile*, std::__1::vector<Profile*, std::__1::allocator<Profile*> > const&) + 231
26  interactive_ui_tests                0x000000011454f558 StartupBrowserCreator::ProcessCmdLineImpl(base::CommandLine const&, base::FilePath const&, bool, Profile*, std::__1::vector<Profile*, std::__1::allocator<Profile*> > const&) + 7480
27  interactive_ui_tests                0x000000011454d6e0 StartupBrowserCreator::Start(base::CommandLine const&, base::FilePath const&, Profile*, std::__1::vector<Profile*, std::__1::allocator<Profile*> > const&) + 304
28  interactive_ui_tests                0x000000010e84632d ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 7885
29  interactive_ui_tests                0x000000010e8443ba ChromeBrowserMainParts::PreMainMessageLoopRun() + 250
30  libcontent.dylib                    0x000000012cf1c831 content::BrowserMainLoop::PreMainMessageLoopRun() + 337
31  libcontent.dylib                    0x000000012cf2336d int base::internal::FunctorTraits<int (content::BrowserMainLoop::*)(), void>::Invoke<content::BrowserMainLoop*>(int (content::BrowserMainLoop::*)(), content::BrowserMainLoop*&&) + 125
32  libcontent.dylib                    0x000000012cf232b4 int base::internal::InvokeHelper<false, int>::MakeItSo<int (content::BrowserMainLoop::* const&)(), content::BrowserMainLoop*>(int (content::BrowserMainLoop::* const&&&)(), content::BrowserMainLoop*&&) + 68
33  libcontent.dylib                    0x000000012cf23243 int base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::RunImpl<int (content::BrowserMainLoop::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > const&, 0ul>(int (content::BrowserMainLoop::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
34  libcontent.dylib                    0x000000012cf2314c base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) + 44
35  libcontent.dylib                    0x000000012e38259d base::RepeatingCallback<int ()>::Run() const & + 61
36  libcontent.dylib                    0x000000012e382470 content::StartupTaskRunner::RunAllTasksNow() + 528
37  libcontent.dylib                    0x000000012cf18691 content::BrowserMainLoop::CreateStartupTasks() + 2769
38  libcontent.dylib                    0x000000012cf263d0 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 2480
39  libcontent.dylib                    0x000000012cf0fd56 content::BrowserMain(content::MainFunctionParams const&) + 550
40  libcontent.dylib                    0x000000012fb97838 content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 600
41  libcontent.dylib                    0x000000012fb98eda content::ContentMainRunnerImpl::Run() + 1322
42  libcontent.dylib                    0x000000012fb8fcb5 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 53
43  libembedder.dylib                   0x000000013e753a20 service_manager::Main(service_manager::MainParams const&) + 2128
44  libcontent.dylib                    0x000000012fb975a6 content::ContentMain(content::ContentMainParams const&) + 86
45  interactive_ui_tests                0x0000000110384b71 content::BrowserTestBase::SetUp() + 8097
46  interactive_ui_tests                0x000000010e67e234 InProcessBrowserTest::SetUp() + 1940
47  interactive_ui_tests                0x000000010b61144e ExtensionBrowserTest::SetUp() + 238
48  interactive_ui_tests                0x000000010ba2297e void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 126
49  interactive_ui_tests                0x000000010b9f4c82 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 114
50  interactive_ui_tests                0x000000010b9f4b64 testing::Test::Run() + 116
51  interactive_ui_tests                0x000000010b9f5bd0 testing::TestInfo::Run() + 224
52  interactive_ui_tests                0x000000010b9f6f9f testing::TestCase::Run() + 239
53  interactive_ui_tests                0x000000010ba0b576 testing::internal::UnitTestImpl::RunAllTests() + 886
54  interactive_ui_tests                0x000000010ba259fe bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 126
55  interactive_ui_tests                0x000000010ba0b182 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 114
56  interactive_ui_tests                0x000000010ba0b05b testing::UnitTest::Run() + 395
57  interactive_ui_tests                0x000000011061d181 RUN_ALL_TESTS() + 17
58  interactive_ui_tests                0x000000011061c4cb base::TestSuite::Run() + 363
59  interactive_ui_tests                0x000000010b81d83f InteractiveUITestSuiteRunner::RunTestSuite(int, char**) + 79
60  interactive_ui_tests                0x000000010e656de3 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 51
61  interactive_ui_tests                0x00000001103c9e72 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 850
[end of stack trace]

Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29?limit=200
First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/877

I'm going to suspect https://chromium-review.googlesource.com/c/chromium/src/+/934311 as it's the CL in the blamelist that seems the most related, but the relation is still very unclear.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c93ce0dff34a64ff092676ce0ab731052bae0cab

commit c93ce0dff34a64ff092676ce0ab731052bae0cab
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Mar 29 16:50:45 2018

Add DCHECK in ExtensionRegistryFactory::GetBrowserContextToUse().

DCHECK that an ExtensionsBrowserClient was set in
ExtensionRegistryFactory::GetBrowserContextToUse().

This is added to diagnose https://crbug.com/827181

TBR=lazyboy@chromium.org

Bug: 827181
Change-Id: I09be86d63a7fcecede803a405d656bce22838740
Reviewed-on: https://chromium-review.googlesource.com/986497
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546853}
[modify] https://crrev.com/c93ce0dff34a64ff092676ce0ab731052bae0cab/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/c93ce0dff34a64ff092676ce0ab731052bae0cab/extensions/browser/extension_registry_factory.cc

Cc: alex...@chromium.org
Owner: boliu@chromium.org
Over to Bo, owner of https://chromium-review.googlesource.com/c/chromium/src/+/934311, to check whether that CL could be related to this, though it seems unlikely to me.

Comment 3 by boliu@chromium.org, Mar 29 2018

Maybe SiteInstanceGotProcess is now called earlier than before now, which probably would be from my change. It's called on the first GetProcess call, apparently. So there are frames inlined in that stack though; can't tell what the frames are between WebContentsImpl::Init and SiteInstanceImpl::GetProcess

what's the expectation here? revert first? work on fix without revert? is there a trybot for this?

Comment 4 by boliu@chromium.org, Mar 29 2018

Oh wait, scratch that theory. WebContentsImpl::Init calls GetProcess here:
https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?rcl=e0c045301ca847e2b20c7df0013bf33be781d34a&l=1756

And that code has been there for years

Comment 5 by boliu@chromium.org, Mar 29 2018

This is green again.. blamelist of first green includes the CL above that only adds DCHECKs. wat?! memory corruption issue?

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/888

Comment 6 by boliu@chromium.org, Mar 29 2018

Cc: boliu@chromium.org
Labels: OS-Mac
Owner: ----
Status: Available (was: Assigned)
I guess my CL (and probably everything in the original blamelist) is off the hook, since they have not been reverted.

I don't know who would be good person to investigate what actually happened though. I don't have any experience working on macs.

Sign in to add a comment