New issue
Advanced search Search tips

Issue 827176 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Calling navigator.credentials.get({publicKey: ...}) from multiple tabs at the same time should not crash

Project Member Reported by engedy@chromium.org, Mar 29 2018

Issue description

Received signal 11 SEGV_MAPERR ffffffffffffffff

base::debug::StackTrace::StackTrace()
base::debug::(anonymous namespace)::StackDumpSignalHandler()
<unknown>
_ZNSt3__16vectorIhNS_9allocatorIhEEE6insertINS_11__wrap_iterIPKhEEEENS_9enable_ifIXaasr21__is_forward_iteratorIT_EE5valuesr16is_constructibleIhNS_15iterator_traitsISA_E9referenceEEE5valueENS5_IPhEEE4typeES8_SA_SA_
device::U2fRequest::GetU2fSignApduCommand()
device::U2fSign::OnTryDevice()
_ZN4base8internal13FunctorTraitsIMN6device7U2fSignEFvNSt3__111__wrap_iterIPKNS4_6vectorIhNS4_9allocatorIhEEEEEENS3_24ApplicationParameterTypeENS_8OptionalIS9_EEEvE6InvokeINS_7WeakPtrIS3_EEJSC_SD_SF_EEEvSH_OT_DpOT0_
_ZN4base8internal31AdaptCallbackForRepeatingHelperIJNS_8OptionalINSt3__16vectorIhNS3_9allocatorIhEEEEEEEE3RunES8_
_ZN4base8internal7InvokerINS0_9BindStateIMNS0_31AdaptCallbackForRepeatingHelperIJNS_8OptionalINSt3__16vectorIhNS5_9allocatorIhEEEEEEEEEFvSA_EJNS5_10unique_ptrISB_NS5_14default_deleteISB_EEEEEEEFvSA_EE3RunEPNS0_13BindStateBaseEOSA_
device::FidoHidDevice::MessageReceived()
_ZN4base8internal13FunctorTraitsIMN6device13FidoHidDeviceEFvNS_12OnceCallbackIFvNS_8OptionalINSt3__16vectorIhNS6_9allocatorIhEEEEEEEEEbNS6_10unique_ptrINS2_14FidoHidMessageENS6_14default_deleteISF_EEEEEvE6InvokeINS_7WeakPtrIS3_EEJNS_17RepeatingCallbackISC_EEbSI_EEEvSK_OT_DpOT0_
_ZN4base8internal7InvokerINS0_9BindStateIMN6device13FidoHidDeviceEFvNS_12OnceCallbackIFvNS_8OptionalINSt3__16vectorIhNS7_9allocatorIhEEEEEEEEEbNS7_10unique_ptrINS3_14FidoHidMessageENS7_14default_deleteISG_EEEEEJNS_7WeakPtrIS4_EENS_17RepeatingCallbackISD_EEEEEFvbSJ_EE7RunOnceEPNS0_13BindStateBaseEbOSJ_
device::FidoHidDevice::OnRead()
_ZN4base8internal13FunctorTraitsIMN6device13FidoHidDeviceEFvNS_12OnceCallbackIFvbNSt3__110unique_ptrINS2_14FidoHidMessageENS5_14default_deleteIS7_EEEEEEEbhRKNS_8OptionalINS5_6vectorIhNS5_9allocatorIhEEEEEEEvE6InvokeINS_7WeakPtrIS3_EEJSC_bhSK_EEEvSM_OT_DpOT0_
_ZN4base8internal7InvokerINS0_9BindStateIMN6device13FidoHidDeviceEFvNS_12OnceCallbackIFvbNSt3__110unique_ptrINS3_14FidoHidMessageENS6_14default_deleteIS8_EEEEEEEbhRKNS_8OptionalINS6_6vectorIhNS6_9allocatorIhEEEEEEEJNS_7WeakPtrIS4_EESD_EEEFvbhSL_EE7RunOnceEPNS0_13BindStateBaseEbhSL_
device::mojom::HidConnection_Read_ForwardToCallback::Accept()
mojo::InterfaceEndpointClient::HandleValidatedMessage()
mojo::FilterChain::Accept()
mojo::InterfaceEndpointClient::HandleIncomingMessage()
mojo::internal::MultiplexRouter::ProcessIncomingMessage()
mojo::internal::MultiplexRouter::Accept()
mojo::FilterChain::Accept()
mojo::Connector::ReadSingleMessage()
mojo::Connector::ReadAllAvailableMessages()
mojo::Connector::OnHandleReadyInternal()
mojo::SimpleWatcher::DiscardReadyState()
mojo::SimpleWatcher::OnHandleReady()
 

Comment 1 by engedy@chromium.org, Mar 29 2018

Summary: Calling navigator.credentials.get({publicKey: ...}) from multiple tabs at the same time should not crash (was: Calling navigator.credentials.get({publicKey:: *}) from multiple tabs at the same time should not crash)

Comment 2 by engedy@chromium.org, Mar 29 2018

Labels: M-67

Comment 3 by engedy@chromium.org, Mar 29 2018

Owner: jdoerrie@chromium.org

Comment 4 by engedy@chromium.org, Mar 29 2018

Description: Show this description

Comment 5 by engedy@chromium.org, Mar 29 2018

Cc: jdoerrie@chromium.org
 Issue 827180  has been merged into this issue.

Comment 6 by engedy@chromium.org, Mar 29 2018

Owner: engedy@chromium.org
Status: Started (was: Available)
This occurs only for sign operations if the fake registration request errors out. Prepared crrev.com/c/986269 to fix.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142a7f1c25f0744e481a0775bfc1b40478246c3e

commit 142a7f1c25f0744e481a0775bfc1b40478246c3e
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Mar 30 14:08:41 2018

U2fSign should expect that the fake registration may also error out.

Bug:  827176 
Change-Id: I582602c9c7bd2f36933285668260e450ae0da9e6
Reviewed-on: https://chromium-review.googlesource.com/986269
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547154}
[modify] https://crrev.com/142a7f1c25f0744e481a0775bfc1b40478246c3e/device/fido/u2f_sign.cc
[modify] https://crrev.com/142a7f1c25f0744e481a0775bfc1b40478246c3e/device/fido/u2f_sign_unittest.cc

Comment 8 by engedy@chromium.org, Mar 30 2018

Status: Fixed (was: Started)

Sign in to add a comment