New issue
Advanced search Search tips

Issue 827172 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Manage the lifetime of the browser-side AuthenticatorImpl properly

Project Member Reported by engedy@chromium.org, Mar 29 2018

Issue description

The implementation should be reliable recreated (and pending requests cancelled) on every navigation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0161d1251761d2f703e61ce539ed3f3eb1c3b466

commit 0161d1251761d2f703e61ce539ed3f3eb1c3b466
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Mar 30 17:23:04 2018

Clean up WebAuth browsertests.

Do some general clean-up and increase robustness:
 -- Reorder some methods/constant declarations,
 -- Add two new tests that use FakeFidoDiscoveries to ensure that
    when there are supposedly simultanenous requests, the first one
    is well underway when the second one starts,
 -- Use ScopedFakeFidoDiscoveryFactory for all tests,
 -- Make tests use TestCallbackReceiver.

Bug:  827172 
Change-Id: Id79210caed7ed03e52b3d8492cccc105313e01e9
Reviewed-on: https://chromium-review.googlesource.com/986512
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547198}
[modify] https://crrev.com/0161d1251761d2f703e61ce539ed3f3eb1c3b466/content/browser/webauth/webauth_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd

commit 0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Mar 30 21:01:17 2018

Manage the lifetime of the browser-side AuthenticatorImpl properly.

The content::AuthenticatorImpl implementation of the corresponding Mojo
interface is now reset (all pending requests dropped) every time the
owning frame navigates cross-document.

The corresonding browser tests have been updated and cleaned up.

Bug:  827172 
Change-Id: I75baf4244a595b101214ecf2385a3851ce6d2710
Reviewed-on: https://chromium-review.googlesource.com/988312
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547268}
[modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/webauth_browsertest.cc

Comment 3 by engedy@chromium.org, Mar 31 2018

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb

commit 46990c9b2ca12500c45ccf0f717f99eb92a6f6cb
Author: Balazs Engedy <engedy@chromium.org>
Date: Sat Mar 31 13:54:48 2018

Do not call NavigationHandle::GetRenderFrameHost for cancelled navigations.

TBR=kpaulhamus@chromium.org

Bug:  827172 
Change-Id: I561b891e0440d59013c7d3da1e46062e96d30a95
Reviewed-on: https://chromium-review.googlesource.com/989552
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547384}
[modify] https://crrev.com/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb/content/browser/webauth/webauth_browsertest.cc

Sign in to add a comment