Manage the lifetime of the browser-side AuthenticatorImpl properly |
||
Issue descriptionThe implementation should be reliable recreated (and pending requests cancelled) on every navigation.
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd commit 0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd Author: Balazs Engedy <engedy@chromium.org> Date: Fri Mar 30 21:01:17 2018 Manage the lifetime of the browser-side AuthenticatorImpl properly. The content::AuthenticatorImpl implementation of the corresponding Mojo interface is now reset (all pending requests dropped) every time the owning frame navigates cross-document. The corresonding browser tests have been updated and cleaned up. Bug: 827172 Change-Id: I75baf4244a595b101214ecf2385a3851ce6d2710 Reviewed-on: https://chromium-review.googlesource.com/988312 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#547268} [modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/authenticator_impl.h [modify] https://crrev.com/0a3d0ccda26ed4a1ab80d7b1ff06d76ff59e82fd/content/browser/webauth/webauth_browsertest.cc
,
Mar 31 2018
,
Mar 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb commit 46990c9b2ca12500c45ccf0f717f99eb92a6f6cb Author: Balazs Engedy <engedy@chromium.org> Date: Sat Mar 31 13:54:48 2018 Do not call NavigationHandle::GetRenderFrameHost for cancelled navigations. TBR=kpaulhamus@chromium.org Bug: 827172 Change-Id: I561b891e0440d59013c7d3da1e46062e96d30a95 Reviewed-on: https://chromium-review.googlesource.com/989552 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547384} [modify] https://crrev.com/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/46990c9b2ca12500c45ccf0f717f99eb92a6f6cb/content/browser/webauth/webauth_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 30 2018