New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827158 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in gl::Compiler::getCompilerHandle

Project Member Reported by ClusterFuzz, Mar 29 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5522519935942656

Fuzzer: mbarbella_webgl
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000160
Crash State:
  gl::Compiler::getCompilerHandle
  gl::Compiler::getBuiltinResourcesString
  gl::Shader::getCompilerResourcesString
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=541517:541570

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5522519935942656

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 29 2018

Labels: Fuzz-Blocker M-67 ReleaseBlock-Beta
This crash occurs very frequently on windows platform and is likely preventing the fuzzer mbarbella_webgl from making much progress. Fixing this will allow more bugs to be found.

Marking this bug as a blocker for next Beta release.

If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
Project Member

Comment 2 by ClusterFuzz, Mar 29 2018

Labels: Test-Predator-Auto-Owner
Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/angle/angle/+/e4c5a23b1148016aace1a282fe9ec8e8ef76a8e8 (Vulkan: Always use LOAD for RenderPass attachments.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 Deleted

Cc: lucferron@chromium.org ynovikov@chromium.org
Fix: https://chromium-review.googlesource.com/c/angle/angle/+/989262

A friendly reminder that M67 branch is coming soon on 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6bc264aee686a8b814e4be1f49e25f1443151c48

commit 6bc264aee686a8b814e4be1f49e25f1443151c48
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Apr 03 17:45:06 2018

Fix potential bad access in LinkProgram.

This could happen when linking a program with missing attachments
and shaders that have no compiled sources.

Also re-enables the EGL program cache control tests, which were
disabled due to a wrong extension name check.

Bug:  chromium:827158 
Change-Id: I181f878093c6e3a4acc51552ade8e7c084733a3d
Reviewed-on: https://chromium-review.googlesource.com/989262
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/6bc264aee686a8b814e4be1f49e25f1443151c48/src/tests/egl_tests/EGLProgramCacheControlTest.cpp
[modify] https://crrev.com/6bc264aee686a8b814e4be1f49e25f1443151c48/src/libANGLE/Program.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c77c86bb59cf2714794797fcff4e8913a26722

commit 39c77c86bb59cf2714794797fcff4e8913a26722
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 04 00:10:01 2018

Roll src/third_party/angle/ 30b604d8d..6bc264aee (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/30b604d8d174..6bc264aee686

$ git log 30b604d8d..6bc264aee --date=short --no-merges --format='%ad %ae %s'
2018-03-31 jmadill Fix potential bad access in LinkProgram.
2018-03-20 oetuaho Collect static use information during parsing
2018-03-21 oetuaho Avoid mangled name comparisons of 3-parameter functions
2018-04-01 fjhenigman Fix conditions for updating element array buffer.

Created with:
  roll-dep src/third_party/angle
BUG= chromium:827158 , chromium:823856 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Idf3b7b345465da375c6dd6ed0f5a934cedc070e8
Reviewed-on: https://chromium-review.googlesource.com/993002
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547880}
[modify] https://crrev.com/39c77c86bb59cf2714794797fcff4e8913a26722/DEPS

Status: Fixed (was: Started)
Project Member

Comment 9 by ClusterFuzz, Apr 4 2018

ClusterFuzz has detected this issue as fixed in range 547876:547880.

Detailed report: https://clusterfuzz.com/testcase?key=5522519935942656

Fuzzer: mbarbella_webgl
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000160
Crash State:
  gl::Compiler::getCompilerHandle
  gl::Compiler::getBuiltinResourcesString
  gl::Shader::getCompilerResourcesString
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=541517:541570
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=547876:547880

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5522519935942656

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: Internals>GPU>ANGLE
Project Member

Comment 11 by ClusterFuzz, Apr 4 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5522519935942656 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment