New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827145 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

164.1% regression in system_health.common_desktop at 546064:546105

Project Member Reported by kraynov@chromium.org, Mar 29 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 29 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=827145

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ea5529c316a8ff647f5f7356faddce8a4e1a32325c9618b88b996c8171d615c8


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 29 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/11bd877b440000
Expanding the range since the value bumps up over multiple data points.
Cc: oysteine@chromium.org eyaich@chromium.org chiniforooshan@chromium.org jam@chromium.org csharrison@chromium.org
Owner: chiniforooshan@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1295b8d8c40000

Add components_perftests to chromium.perf.json by csharrison@chromium.org
https://chromium.googlesource.com/chromium/src/+/a33ba78b7502b9bfad38cfd48fa5f8ff698bac79

Fix startup tracing in renderers by chiniforooshan@chromium.org
https://chromium.googlesource.com/chromium/src/+/f192e8a25e1937336d9cc16f9273b1d13b99530a

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -jam@chromium.org dproy@chromium.org
Status: WontFix (was: Assigned)
I believe this is not a regression. It is a logging issue that my CL fixed.

- My CL fixed startup tracing, which means now we see more early trace events.

- The way timeToFirstPaint is calculated is that for every firstPaint event of the main frame we find the corresponding navigationStart event before it and compute the duration from navigationStart to firstPaint.

- Before my CL, the first navigationStart event was not logged and so one large timeToFirstPaint was not reported. After my CL, we see all navigationStart events and so report more timeToFirstPaint values.

+dproy@ for verification.
Cc: jam@chromium.org
 Issue 827146  has been merged into this issue.
 Issue 827149  has been merged into this issue.
 Issue 827150  has been merged into this issue.

Comment 11 by dproy@chromium.org, Apr 17 2018

Cc: sullivan@chromium.org
Verified c#7. 

Although it looks like we now have two firstPaint samples, and the the URL for the new first paint is "https://myaccount.google.com/?pli=1" (so this is the login page), while the URL for the other first paint is "mail.google.com/mail". Someone who has more context into this benchmark should verify this was the original intention. 
Cc: nednguyen@chromium.org kouhei@chromium.org
+Ned and Kouhei about the multiple urls in #11.
Cc: npm@chromium.org
 Issue 826827  has been merged into this issue.

Sign in to add a comment