New issue
Advanced search Search tips

Issue 827131 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

File read into memory without size limit in DeleteOldAndRecentWebRtcLogFiles()

Project Member Reported by eladalon@chromium.org, Mar 29 2018

Issue description

Reading an entire file into memory, without guarding against the file's maximum size, is a risky endeavour.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4532d1fcc12e05f02486d8e8314220ce1947e3

commit 4a4532d1fcc12e05f02486d8e8314220ce1947e3
Author: Elad Alon <eladalon@chromium.org>
Date: Thu Apr 05 16:59:05 2018

Fix removal of old entries from chrome://webrtc-logs

When WebRTC textual log files are deleted, either because of
expiration or because the user clears browsing history,
entries from the logs' index are now also removed.

As a drive-by:
* Fixed the unbounded reading of a file into memory.
* Marked with TODOs (and filed bugs) for several other
  problems found.

Bug:  825977 ,  827131 
Change-Id: If34acf6290ec90c3ce99c0704c58bc8a8188f92d
Reviewed-on: https://chromium-review.googlesource.com/982055
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548455}
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup.cc
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup.h
[modify] https://crrev.com/4a4532d1fcc12e05f02486d8e8314220ce1947e3/components/webrtc_logging/browser/log_cleanup_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment