New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827126 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non- Regression : Default cursor is seen missing in Password text field of Confirm your password' dialog box after refreshing the chrome://settings page

Project Member Reported by mmanchala@chromium.org, Mar 29 2018

Issue description

Chrome Version:   67.0.3381.0/10525.0.0 dev channel Daisy,Kip,Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
2)In Confirm your password' dialog box observe default cursor is seen in Text field -> Now refresh the page and observe cursor is seen  missing in Password text field
(Please refer Video and screenshot)

Note : Click on 'Manage search engines' at 'Search engine -> Now place cursor at 'Search settings' search box -> reload the page and observe default cursor will be seen at 'Search settings' search box
(Please refer 'Expected_Cursor' Video)

Expected:  Default cursor should be seen in Password text field even after refreshing the page
Actual: Instead  Default cursor is seen missing in Password text field after refreshing the page

This is Non-Regression Issue as 'Screen lock' option is introduced from M-57.

@sammiequon : Please confirm the Issue
 
Actual_NoCursor.webm
803 KB View Download
Expected_Cursor.webm
989 KB View Download
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ded99fb53f4c236bbd3b1a3ee4641f648b91c200

commit ded99fb53f4c236bbd3b1a3ee4641f648b91c200
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Apr 12 20:40:58 2018

settings: Fix focus issues with lock screen.

1) Fix pin keyboard shifting when going from message to no message.
2) Fix loosing focus on input when clicking disabled backspace - it will
also not loose focus anymore if anywhere on the PIN keyboard is clicked.
3) Fix no focus on input when directly going to lockscreen
(chrome:settings/lockScreen).

Test: manual
Bug: 828450,  827948 ,  827126 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id64b80287c6667a419f186cf67d7b77c62cf02d1
Reviewed-on: https://chromium-review.googlesource.com/1006262
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550345}
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ded99fb53f4c236bbd3b1a3ee4641f648b91c200

commit ded99fb53f4c236bbd3b1a3ee4641f648b91c200
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Apr 12 20:40:58 2018

settings: Fix focus issues with lock screen.

1) Fix pin keyboard shifting when going from message to no message.
2) Fix loosing focus on input when clicking disabled backspace - it will
also not loose focus anymore if anywhere on the PIN keyboard is clicked.
3) Fix no focus on input when directly going to lockscreen
(chrome:settings/lockScreen).

Test: manual
Bug: 828450,  827948 ,  827126 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id64b80287c6667a419f186cf67d7b77c62cf02d1
Reviewed-on: https://chromium-review.googlesource.com/1006262
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550345}
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js

Sign in to add a comment