Issue metadata
Sign in to add a comment
|
Regression:Restore bubble appears misplaced on resizing browser from RHS after enabling RTL flags
Reported by
vineetha...@etouch.net,
Mar 29 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3383.0 (Official Build)Revision b6c093c42e2a0eb8c2d8c9dc76171b59dc65568d-refs/heads/master@{#546671}(64 bit) OS: Mac(10.12.6, 10.13.1, 10.13.4) OS Pre-condition: Set 'Force UI direction' flag to 'Right-to-left' and enable the 'Enable RTL' flag under chrome://flags What steps will reproduce the problem? (1) Launch Chrome, open NTP and enter chrome://inducebrowsercrashforrealz/ in omnibox. (2) Now relaunch chrome and observe the Restore bubble after resizing the browser from RHS. Actual Result: Restore bubble appears misplaced on resizing browser from RHS. Expected Result: Restore bubble should not get misplaced on resizing browser from RHS. This is regression issue broken in ‘M-67’ and providing the bisect using per-revision bisect, Good build: 67.0.3381.0(Revision: 545919) Bad build: 67.0.3382.0(Revision: 546346) You are probably looking for a change made after 546150 (known good), but no later than 546151 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/a783ac29716b05560ef605df0e9d2665ab3010bd..83c3f7662808f7fb7e78f2ac7921280e54e82f59 Suspect: https://chromium.googlesource.com/chromium/src/+/83c3f7662808f7fb7e78f2ac7921280e54e82f59 @ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This issue is not observed on Windows (7,8,8.1,10) & Linux(14.04 LTS) OS Thank You!
,
Mar 29 2018
,
Mar 29 2018
Reproduced locally.
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8beda3f6ab28ec4d473e5bfd33ceb9a6f6cb86e commit e8beda3f6ab28ec4d473e5bfd33ceb9a6f6cb86e Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 29 18:37:35 2018 macviews: fix KeepBubbleAnchored() in RTL When in RTL mode, bubbles with a *right* arrow (which in LTR mode are on the right side of the window) appear on the left, so their MinX should become fixed. Similarly, bubbles with a *left* arrow appear on the right, so their MinX should be variable. Bug: 827123 Change-Id: I557cdfaa84a94d5ee431c210730b156c60d20105 Reviewed-on: https://chromium-review.googlesource.com/986276 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546874} [modify] https://crrev.com/e8beda3f6ab28ec4d473e5bfd33ceb9a6f6cb86e/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
,
Mar 29 2018
,
Mar 30 2018
Update : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.4) OS with latest Canary Chrome version #67.0.3384.0 and the issue is fixed. Kindly refer the attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Mar 29 2018