New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827122 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Gallery button is seen enabled in New camera app

Project Member Reported by kebalaji@chromium.org, Mar 29 2018

Issue description

Chrome Version:67.0.3381.0/10525.0.0 dev channel Daisy,Kip,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign in to user>> Install New camera app version: 5.0.0( https://chrome.google.com/webstore/detail/msgname-canary/afoodkbadjkccjlgmeldfjefkfgpalan?hl=en-US&gl=US&authuser=0 )
(2)Now open camera app and observe>> the gallery icon is not clickable but is seen enabled

Actual: When the gallery icon is not clickable it should be seen enabled
Expected: Gallery icon should be seen disabled

This is a Non-Regression issue able to reproduce across all milestones

@Yuli: Please confirm the issue
 
ActualNewCamera.mp4
4.9 MB View Download
Cc: ajha@chromium.org brajkumar@chromium.org
Components: Platform>Apps>Camera
Labels: -Pri-3 Inhouse-HYD-Reported M-67 Pri-2
Summary: Non-Regression: Gallery button is seen enabled in New camera app (was: Non-Regression: Gallery button is seen enabled in New czmera app)
Labels: OS-Chrome

Comment 3 by y...@chromium.org, Mar 31 2018

The gallery button is disabled (working as expected); however, the dimmed opacity for disabled buttons might not be noticeable enough. (It applies to all buttons in camera app: 75% opacity for disabled buttons, and 100% opacity for enabled buttons.) I'll change the dimmed opacity to 70% for all disabled buttons and see if it works better.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/bdd331329457db383de48258b134d61c962610c6

commit bdd331329457db383de48258b134d61c962610c6
Author: Yuli Huang <yuli@chromium.org>
Date: Tue Apr 03 01:23:30 2018

Fix disabled buttons' dimmed opacity.

BUG= chromium:827122 
TEST=Tested manually on elm.

Change-Id: Ie70694a3b01ba6dee5a2d8c7a6910f3d6ddf049d
Reviewed-on: https://chromium-review.googlesource.com/989357
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/bdd331329457db383de48258b134d61c962610c6/src/css/main.css

Comment 5 by y...@chromium.org, Apr 3 2018

Status: Fixed (was: Assigned)
Please verify the fix after the canary is updated. Thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdd331329457db383de48258b134d61c962610c6

commit bdd331329457db383de48258b134d61c962610c6
Author: Yuli Huang <yuli@chromium.org>
Date: Tue Apr 03 01:23:30 2018

Fix disabled buttons' dimmed opacity.

BUG= chromium:827122 
TEST=Tested manually on elm.

Change-Id: Ie70694a3b01ba6dee5a2d8c7a6910f3d6ddf049d
Reviewed-on: https://chromium-review.googlesource.com/989357
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/bdd331329457db383de48258b134d61c962610c6/src/css/main.css

Sign in to add a comment