New issue
Advanced search Search tips

Issue 827112 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

'Main menu' overlay gets closed in 'Settings' page after clicking on 'Extension' option.

Reported by db...@etouch.net, Mar 29 2018

Issue description

Chrome Version : 67.0.3383.0 (Official Build) b6c093c42e2a0eb8c2d8c9dc76171b59dc65568d-refs/heads/master@{#546671} 32/64-bit
OS : Windows(7,8,8.1,10), Linux(14.04 LTS),Mac(10.12.6,10.13.1,10.13.4)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings page and click on 'Main menu' icon.
(2) Click on 'Extension' option(chrome://extensions page gets opened) come back to chrome://settings page
(3) Observe 'Main menu' overlay.

Actual: 'Main menu' overlay gets closed after clicking on Extension option.

Expected: 'Main menu' overlay should not gets closed after clicking on Extension option.

This is a non-regression issue, seen from 'M67' build #67.0.3382.0


 
Actual_Overlay.mp4
926 KB View Download
Status: Untriaged (was: Unconfirmed)

Comment 2 by dpa...@chromium.org, Mar 29 2018

Cc: aee@chromium.org namratakannan@chromium.org
Status: Assigned (was: Untriaged)
@aee: Can you check with UX (cc'ed) to verify whether the menu should close upon clicking the Extensions link?

Comment 3 by dpa...@chromium.org, Mar 29 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org

Comment 4 by aee@chromium.org, Mar 29 2018

Status: Started (was: Assigned)
I talked with @namratakannan. The menu drawer should remain open after clicking on external links.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fbe5725e470f111fbd8f79e66021d005b70b1c4

commit 7fbe5725e470f111fbd8f79e66021d005b70b1c4
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Mar 29 21:59:27 2018

Settings WebUI: leave settings menu drawer open after clicking extensions (external) link

Bug:  827112 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5f92210573a235f67cc919ab4b7e2082c3f9b75e
Reviewed-on: https://chromium-review.googlesource.com/986662
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546973}
[modify] https://crrev.com/7fbe5725e470f111fbd8f79e66021d005b70b1c4/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/7fbe5725e470f111fbd8f79e66021d005b70b1c4/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/7fbe5725e470f111fbd8f79e66021d005b70b1c4/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/7fbe5725e470f111fbd8f79e66021d005b70b1c4/chrome/test/data/webui/settings/settings_menu_test.js

Comment 6 by aee@chromium.org, Mar 29 2018

Status: Fixed (was: Started)

Sign in to add a comment