New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827101 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

For very low level echo in silent backgrounds, the AEC3 linear filter fails to report convergence

Project Member Reported by peah@chromium.org, Mar 29 2018

Issue description

Due to a too high set threshold, fr very low level echo in silent backgrounds, the AEC3 linear filter fails to report convergence.
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/971bf03ee47f2d4d430a8cc8dc3c09d87c31ffff

commit 971bf03ee47f2d4d430a8cc8dc3c09d87c31ffff
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Mar 29 11:31:57 2018

Corrected the threshold for determining filter convergence in AEC3

Bug:  webrtc:9087 , chromium:827101 
Change-Id: Ic1da3bc2877a406b80affff68143766761e24c13
Reviewed-on: https://webrtc-review.googlesource.com/65501
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22675}
[modify] https://crrev.com/971bf03ee47f2d4d430a8cc8dc3c09d87c31ffff/modules/audio_processing/aec3/subtractor.cc

Comment 2 by peah@chromium.org, Mar 29 2018

Labels: Merge-Approved-66
I would like to ask for a merge of this to M66. 

The code change has just landed and has not had time to bake in Canary so it should bake for a couple of days, but since it is so close to Stable release, and the easter holidays are inbetween, I ask already now. 

The change has been verified to work well in offline simulations based on aecdump recordings. 
The change is very safe in the sense that it is only active beneath an experimental flag which can be used to turn off the feature.  


Comment 3 by peah@chromium.org, Mar 29 2018

Labels: -Merge-Approved-66

Comment 4 by peah@chromium.org, Mar 29 2018

Labels: Merge-Request-66
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 29 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: Less than 15 days to go before AppStore submit on M66
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by peah@chromium.org, Mar 29 2018

(I by mistake added the Merge-aAproved-66 label instead of Merge-Request-66 label. That is now corrected.)

Comment 7 by cmasso@google.com, Mar 29 2018

M66 beta builds for this week are already shipped so we have time to verify this in canary before merging it into M66. 

Could you also explain a little more why this should be in M66? What's the rationale behind the merge.

Comment 8 by peah@chromium.org, Mar 29 2018

Good, then lets wait until after the weekend.

The rationale behind the merge is that a regression in the headset behavior for the echo canceller was introduced in M64 and/or M65, causing very choppy audio. It was discovered during the M65 Stable rollout and a first patch was merged last week to handle that. 

During testing this week, it was discovered that for some headsets which leak low-level echo a threshold in the merged patch was set too large, causing full echo for those headsets.

The patch in this CL lower that threshold by a factor 4 which handles these headsets identified.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99fe96fc2e9a19d26e85756f203e5cb09e8ac0b4

commit 99fe96fc2e9a19d26e85756f203e5cb09e8ac0b4
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Mar 29 18:35:19 2018

Roll src/third_party/webrtc/ 7abc9a07d..a21090b77 (15 commits)

https://webrtc.googlesource.com/src.git/+log/7abc9a07d774..a21090b7706e

$ git log 7abc9a07d..a21090b77 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:827080 , chromium:827101 ,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I26226844a15fd3ed25ded98c0563fbeb5bd2ca3e
Reviewed-on: https://chromium-review.googlesource.com/986413
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546870}
[modify] https://crrev.com/99fe96fc2e9a19d26e85756f203e5cb09e8ac0b4/DEPS

Comment 10 by cmasso@google.com, Mar 29 2018

What is the merge request for if CLs are still landing?

Comment 11 by peah@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)
You mean the message in comment #9, right?

That is the message from the bot doing the automatic import of WebRTC into Chromium. I'm not sure why that was appended into this issue. That seems to be a newly change in the import system that causes that (I guess the reason it was added is that this issue was part of that import).

The import is not part of the CL for this issue though. The only CL for the issue is listed in #1.

Comment 12 by cmasso@google.com, Mar 30 2018

Please verify in canary and update back here.

Comment 13 by peah@chromium.org, Apr 2 2018

The change is now verified in Canary and the results look good. 

Given that, we would like to do this merge if possible.
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 2 2018

Labels: merge-merged-66
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/934825ecd5d00c44b992a733d3693716fa0632a6

commit 934825ecd5d00c44b992a733d3693716fa0632a6
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Apr 02 21:53:48 2018

Merge to M66: Corrected the threshold for determining filter ...

(cherry picked from commit 971bf03ee47f2d4d430a8cc8dc3c09d87c31ffff)

TBR: henrik.lundin@webrtc.org, saza@webrtc.org
Bug:  webrtc:9087 , chromium:827101 
Change-Id: Ic1da3bc2877a406b80affff68143766761e24c13
Reviewed-on: https://webrtc-review.googlesource.com/65501
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#22675}
Reviewed-on: https://webrtc-review.googlesource.com/66240
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/66@{#15}
Cr-Branched-From: 12c8110e8c717b7f0f87615d3b99caac2a69fa6c-refs/heads/master@{#22215}
[modify] https://crrev.com/934825ecd5d00c44b992a733d3693716fa0632a6/modules/audio_processing/aec3/subtractor.cc

Comment 16 by peah@chromium.org, Apr 2 2018

Labels: M-66
Labels: -Merge-Approved-66

Sign in to add a comment