New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 864886



Sign in to add a comment

[bisect-kit] Failed to bisect between 10502.0.0 and 10503.0.0

Project Member Reported by deanliao@chromium.org, Mar 29 2018

Issue description

Use crosperf-bisect.py (in team-git: https://team.git.corp.google.com/perfcsicros-taiwan/bisect_kit/) to bisect a regression https://bugs.chromium.org/p/chromium/issues/detail?id=826628

./crosperf-bisect.py bisect_crbug_826628.json

All local builds between endpoint are all failed (see ChromeOSRepoDomain).

The root cause could be webrtc-apm repo was newly added between 10502..10503 but repo sync always sync to 10502, causes third_party/webrtc-apm not found.

https://crosland.corp.google.com/log/10502.0.0..10503.0.0
https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/07117811d9c5e646e9c853f1b7f76ca5a6639e8a
 
results.json
24 bytes View Download
ChromeOSRepoDomain
66.1 KB View Download
bisect-kit.log.gz
3.9 MB Download
bisect_crbug_826628.json
286 bytes View Download
Blockedon: 864886
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf

commit e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Tue Jul 24 11:43:42 2018

bisect-kit: migrate chromeos bisector to use codechange module

After this CL, chromeos localbuild bisector is more robust and can
handle following issues:
 - add and remove repo projects
 - manifest snapshot racing

Like android local build bisector, the setup step of chromeos checkout
is changed as well. Now you have to make a repo mirror and sync the
tree from the mirror. The exact steps are:

 1. setup a repo mirror
    $ cd $CHROMEOS_REPO_MIRROR_DIR
    $ repo init ...<original flags>... --mirror
    $ mkdir .repo/local_manifests
    $ cat << END > .repo/local_manifests/manifest-versions.xml
    <?xml version="1.0" encoding="UTF-8"?>
    <manifest>
      <project name="chromeos/manifest-versions" remote="cros-internal" />
    </manifest>
    END
    $ repo sync

 2. checkout chromeos tree from the mirror
    $ cd $CHROMEOS_ROOT
    $ repo init ...<original flags>...  --reference=$CHROMEOS_REPO_MIRROR_DIR
    $ repo sync

 3. specify --chromeos_repo_mirror_dir $CHROMEOS_REPO_MIRROR_DIR when you
    use bisect_cros_repo.py and switch_cros_localbuild.py

Due to  crbug.com/864886 , this bisector can only work with version of
chromite after 2018-07-19. Workaround will be provided in separate CL
later.

BUG= chromium:827092 
TEST=unit test and following commands
$ ./bisect_cros_repo.py init --old R69-10883.0.0 --new R69-10884.0.0 \
  --chromeos_root $CHROMEOS_ROOT \
  --chromeos_repo_mirror_dir $CHROMEOS_REPO_MIRROR_DIR \
  --board samus
$ ./switch_cros_localbuild.py samus-test R69-10883.0.0~R69-10884.0.0/10 \
  --chromeos_root $CHROMEOS_ROOT \
  --chromeos_repo_mirror_dir $CHROMEOS_REPO_MIRROR_DIR

Change-Id: I594d850f80a9ff05b7241106bdc7ff191cf12676
Reviewed-on: https://chromium-review.googlesource.com/1143114
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chi-Ngai Wan <cnwan@google.com>

[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/git_util_test.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/repo_util_test.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/cr_util.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/switch_arc_localbuild.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_cros_repo.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/git_util.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/android_util.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/codechange.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/cros_util.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/bisect_kit/repo_util.py
[modify] https://crrev.com/e4bae0bcfb7eed458a7bd0aff9aae250e3f76eaf/switch_cros_localbuild.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/94f48e5b82be8ce00e6ed18eef00508011f6cdc1

commit 94f48e5b82be8ce00e6ed18eef00508011f6cdc1
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed Aug 01 12:05:26 2018

bisect-kit: update dianoser after chromeos and android bisectors change

BUG= chromium:827092 
TEST=dianose_cros_autotest.py

Change-Id: I6ff954f6693b61dc2a1ec7aefad9bc5fc5bc2ebb
Reviewed-on: https://chromium-review.googlesource.com/1158308
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/94f48e5b82be8ce00e6ed18eef00508011f6cdc1/bisect_kit/diagnoser_cros.py
[modify] https://crrev.com/94f48e5b82be8ce00e6ed18eef00508011f6cdc1/bisect_android_repo.py
[modify] https://crrev.com/94f48e5b82be8ce00e6ed18eef00508011f6cdc1/bisect_cros_repo.py
[modify] https://crrev.com/94f48e5b82be8ce00e6ed18eef00508011f6cdc1/diagnose_cros_autotest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/f41599ccd93ae7660ba1b234a460b98b8f4bd497

commit f41599ccd93ae7660ba1b234a460b98b8f4bd497
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Mon Aug 06 17:17:40 2018

bisect-kit: fix chromeos local build cache path

Intra version string was changed to format 'X~Y/Z'. However, '/' is
invalid as folder name. Replace it with another character for image
cache path.

BUG= chromium:827092 
TEST=./switch_cros_localbuild.py

Change-Id: I602cd2d70aa19a8e6077c73a2305252b09b9c142
Reviewed-on: https://chromium-review.googlesource.com/1161847
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/f41599ccd93ae7660ba1b234a460b98b8f4bd497/bisect_kit/cros_util.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/2245526eb1de4d458442e12df4d212d896954a71

commit 2245526eb1de4d458442e12df4d212d896954a71
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Tue Aug 07 10:43:33 2018

bisect-kit: revise ActionGroup serialization

Currently, chromeos local build bisector may fail when manifest glitch
occurs because
 1. ActionGroup comment was not serialized
 2. Multiple Actions in single ActionGroup was not supported

BUG= chromium:827092 
TEST=after init, run './bisect_cros_repo.py view'

Change-Id: Ibefe5a38583ebf5601ee478da8b858368cc6c160
Reviewed-on: https://chromium-review.googlesource.com/1161844
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/2245526eb1de4d458442e12df4d212d896954a71/bisect_kit/codechange.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/6948eccf7c61668b71ea22f257a7560b9931d224

commit 6948eccf7c61668b71ea22f257a7560b9931d224
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Tue Sep 18 10:49:48 2018

bisect-kit: switch source version while maintaining project list

After bisectors migrated to use codechange module, they can enumerate
changes with add/del repos. This CL adds support of source code version
switching.

BUG= chromium:827092 
TEST=test following cases:
(unrelated command line options are skipped)
 - repo case 1
   ./bisect_cros_repo.py init --old R67-10502.0.0 --new R67-10503.0.0
   ./switch_cros_localbuild.py R67-10502.0.0~R67-10503.0.0/46
 - repo case 2
   ./bisect_cros_repo.py init --old R70-10907.0.0 --new R70-10908.0.0
   ./switch_cros_localbuild.py R70-10907.0.0~R70-10908.0.0/68
 - gclient
   ./bisect_cros_localbuild_internal.py init --old 70.0.3509.0 --new 70.0.3510.0

Change-Id: I416baf916fcdf7e7a80dbbde562469d290e5b2b4
Reviewed-on: https://chromium-review.googlesource.com/1218248
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/6948eccf7c61668b71ea22f257a7560b9931d224/bisect_kit/gclient_util.py
[modify] https://crrev.com/6948eccf7c61668b71ea22f257a7560b9931d224/bisect_kit/git_util.py
[modify] https://crrev.com/6948eccf7c61668b71ea22f257a7560b9931d224/bisect_kit/codechange.py
[modify] https://crrev.com/6948eccf7c61668b71ea22f257a7560b9931d224/bisect_kit/repo_util.py

Status: Fixed (was: Assigned)
repo add/remove should be supported by recent bisect-kit changes.

Sign in to add a comment