New issue
Advanced search Search tips

Issue 827067 link

Starred by 1 user
Status: Fixed
Owner:
machenb...@chromium.org
Closed: Apr 2018
Cc:
yangguo@chromium.org
leszeks@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue v8:7608
issue 829231
Blocking:
issue 826613



Sign in to add a comment

Teach fuzzer about --noanalyze-environment-liveness

Project Member Reported by bmeu...@chromium.org, Mar 29 2018 
Relevant design document: https://docs.google.com/document/d/1AnsQpiWdtEuacKoYloVktHcX2m2fnuWmuFjiLaijxs4

We want to have the debugger forcibly disable liveness analysis in TurboFan, which is already exposed via the --noanalyze-environment-liveness command line option, in order to improve developer experience. So we should have fuzzer coverage for this configuration as well, like at least the correctness fuzzer should test with this feature disabled to make sure we produce the same results.

Comment 1 by machenb...@chromium.org, Apr 4 2018 

To clarify, we should pass --noanalyze-environment-liveness since --analyze-environment-liveness is the default?

I can add a correctness fuzzer config. I assume this flag makes only sense with turbofan. Is it useful to combine it with --always-opt in a separate config?

Additionally we can add a trial on clusterfuzz for other fuzzers.

Comment 2 by bmeu...@chromium.org, Apr 5 2018 

Yes, pass --noanalyze-environment-liveness and that only makes sense with TurboFan. It's probably useful to combine with --always-opt in a separate config.

Comment 3 by machenb...@chromium.org, Apr 5 2018

Blockedon: 829231
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/adf7ee179117915f024241cb61d56255298fdbbc

commit adf7ee179117915f024241cb61d56255298fdbbc
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Apr 05 07:22:34 2018

[foozzie] Add trial for --noanalyze-environment-liveness

NOTRY=true

Bug:  chromium:827067 
Change-Id: I05073fd85b8b1b1545d5c2be55676aed237d1c10
Reviewed-on: https://chromium-review.googlesource.com/997292
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52376}
[modify] https://crrev.com/adf7ee179117915f024241cb61d56255298fdbbc/tools/clusterfuzz/v8_foozzie.py

Comment 5 by machenb...@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)
Done. Also trial on clusterfuzz... see blocking bug.
►

Sign in to add a comment