Forbid SequencedTaskRunnerHandle::Get usages under content/renderer |
|||
Issue descriptionNow there are only 5 usages of STRH::Get() under content/renderer, let's remove them and forbid introducing new usages by the presubmit script. Related: crbug/786332
,
Mar 29 2018
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aad0f7fa26d93f81a62ac6685aa997e1463b6d0a commit aad0f7fa26d93f81a62ac6685aa997e1463b6d0a Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Apr 02 03:42:54 2018 media: Remove SequencedTaskRunnerHandle::Get() usages in UserMediaClientImpl This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I4a062ac1db4631215d1ec58bd5d79cc3acc5ba33 Reviewed-on: https://chromium-review.googlesource.com/987833 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547409} [modify] https://crrev.com/aad0f7fa26d93f81a62ac6685aa997e1463b6d0a/content/renderer/media/stream/user_media_client_impl.cc
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/440f5bdfc8fd5d45b9d483737da09d54b489ce86 commit 440f5bdfc8fd5d45b9d483737da09d54b489ce86 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Apr 06 05:34:27 2018 Remove SequencedTaskRunnerHandle::Get() usages in MojoAudioOutputIPC This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I6b4d582ba9e1d53dfddebacc8baec199eb311271 Reviewed-on: https://chromium-review.googlesource.com/985995 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#548683} [modify] https://crrev.com/440f5bdfc8fd5d45b9d483737da09d54b489ce86/content/renderer/media/audio_output_ipc_factory.cc [modify] https://crrev.com/440f5bdfc8fd5d45b9d483737da09d54b489ce86/content/renderer/media/mojo_audio_output_ipc.cc [modify] https://crrev.com/440f5bdfc8fd5d45b9d483737da09d54b489ce86/content/renderer/media/mojo_audio_output_ipc.h [modify] https://crrev.com/440f5bdfc8fd5d45b9d483737da09d54b489ce86/content/renderer/media/mojo_audio_output_ipc_unittest.cc [modify] https://crrev.com/440f5bdfc8fd5d45b9d483737da09d54b489ce86/content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/187b7adc6270df1675d59195a20dce90571b6e4f commit 187b7adc6270df1675d59195a20dce90571b6e4f Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Apr 06 09:10:10 2018 media: Remove SequencedTaskRunnerHandle::Get() usages in UserMediaClientImpl This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I07e9d3d051c0d4b01aeeafd86e06716ed8473af7 Reviewed-on: https://chromium-review.googlesource.com/987594 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548719} [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/media/stream/apply_constraints_processor.cc [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/media/stream/apply_constraints_processor.h [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/media/stream/user_media_client_impl.cc [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/media/stream/user_media_client_impl.h [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/media/stream/user_media_client_impl_unittest.cc [modify] https://crrev.com/187b7adc6270df1675d59195a20dce90571b6e4f/content/renderer/render_frame_impl.cc
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9505eb437629b6090551ca0375c6e19e1fd1342f commit 9505eb437629b6090551ca0375c6e19e1fd1342f Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Apr 10 09:13:02 2018 loader: Remove SequencedTaskRunnerHandle::Get() usages in TrackedChildURLLoaderFactoryBundle This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I6dc555a31615371f10e082a27f894a6b2fcbf981 Reviewed-on: https://chromium-review.googlesource.com/987596 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549463} [modify] https://crrev.com/9505eb437629b6090551ca0375c6e19e1fd1342f/content/renderer/loader/tracked_child_url_loader_factory_bundle.cc [modify] https://crrev.com/9505eb437629b6090551ca0375c6e19e1fd1342f/content/renderer/loader/tracked_child_url_loader_factory_bundle.h [modify] https://crrev.com/9505eb437629b6090551ca0375c6e19e1fd1342f/content/renderer/render_frame_impl.cc
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1230a8a45e736582f2352ad8c54201a4d490f3a2 commit 1230a8a45e736582f2352ad8c54201a4d490f3a2 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Apr 11 04:42:30 2018 Forbid newly introducing ThreadTaskRunnerHandle/SequencedTaskRunnerHandle::Get() In most cases, using ThreadTaskRunnerHandle::Get() or SequencedTaskRunnerHandle::Get() in renderers is semantically wrong. Additionally, these task usage prevents flexible renderer scheduing, e.g. throttling tasks for a hidden iframe. This CL introduces presubmit checks to forbide newly introducing those Get() usages. Bug: 827065 Change-Id: I92cd9d4207d5664e42763939e5c1c8d293897799 Reviewed-on: https://chromium-review.googlesource.com/995241 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549759} [add] https://crrev.com/1230a8a45e736582f2352ad8c54201a4d490f3a2/content/renderer/PRESUBMIT.py [add] https://crrev.com/1230a8a45e736582f2352ad8c54201a4d490f3a2/content/renderer/PRESUBMIT_test.py
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cfab05a01081a3bae1d4b21f41c6e0456cb7504 commit 3cfab05a01081a3bae1d4b21f41c6e0456cb7504 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Apr 11 05:50:46 2018 autofill: Remove SequencedTaskRunnerHandle::Get() usages in FormTracker This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: Ibe964c87e8e0244621610e2eacd0842111e351e8 Reviewed-on: https://chromium-review.googlesource.com/1002797 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549785} [modify] https://crrev.com/3cfab05a01081a3bae1d4b21f41c6e0456cb7504/components/autofill/content/renderer/form_tracker.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8 commit 9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Apr 13 03:35:04 2018 autofill: Remove SequencedTaskRunnerHandle::Get() usages in AutofillAgent This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: Ia95e37e8d28d41fbf56ece38fedda14da6a64060 Reviewed-on: https://chromium-review.googlesource.com/1009683 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550486} [modify] https://crrev.com/9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8/components/autofill/content/renderer/autofill_agent.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8 commit 9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Apr 13 03:35:04 2018 autofill: Remove SequencedTaskRunnerHandle::Get() usages in AutofillAgent This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: Ia95e37e8d28d41fbf56ece38fedda14da6a64060 Reviewed-on: https://chromium-review.googlesource.com/1009683 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550486} [modify] https://crrev.com/9f80e74b14231cb9c4fe0d5ce33b6e0d6df72aa8/components/autofill/content/renderer/autofill_agent.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by hajimehoshi@chromium.org
, Mar 29 2018