New issue
Advanced search Search tips

Issue 827060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: WebViewTests/WebViewDPITest.Shim_TestAutosizeBeforeNavigation/1



Sign in to add a comment

WebViewTests/WebViewDPITest.Shim_TestAutosizeBeforeNavigation/1 is Flaky

Project Member Reported by Findit, Mar 29 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec4cca899117d5044698711b81bb57141812fbf

commit 7ec4cca899117d5044698711b81bb57141812fbf
Author: kylechar <kylechar@chromium.org>
Date: Thu Mar 29 13:24:38 2018

Revert "Ozone X11 check X display on initialization."

This reverts commit b0770c15dc9aa7020829bb421fb88e4dc2ff7347.

Reason for revert:  https://crbug.com/827060 , the CHECK should happen after the call to XInitThreads().

Original change's description:
> Ozone X11 check X display on initialization.
> 
> Add a CHECK that XOpenDisplay() doesn't return null when initializing
> Ozone X11. There is no point going any further, we are going to crash
> somewhere else and the crash stack isn't going to be as obvious.
> 
> Bug:  806508 
> Change-Id: Ibdde13298d160cf4aff8420222a56af9fa303d22
> Reviewed-on: https://chromium-review.googlesource.com/980596
> Commit-Queue: kylechar <kylechar@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546655}

TBR=sadrul@chromium.org,kylechar@chromium.org

Change-Id: Idc86201a90a714c0a043ff48570582597d1e0257
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  806508 ,  827060 
Reviewed-on: https://chromium-review.googlesource.com/985958
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546804}
[modify] https://crrev.com/7ec4cca899117d5044698711b81bb57141812fbf/ui/ozone/platform/x11/ozone_platform_x11.cc

Owner: kylec...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment