New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 827023 link

Starred by 1 user
Status: Fixed
Owner:
baileyberro@chromium.org
Closed: May 2018
Cc:
█ mtomasz@google.com
fukino@chromium.org
zentaro@chromium.org
█ allenvic@chromium.org
Components:
EstimatedDays: 0
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Adding SmbMount causes crash

Project Member Reported by baileyberro@chromium.org, Mar 29 2018 
What steps will reproduce the problem?
1. Enable 'NativeSmb' flag
2. Open files app and click add services button 
3. Select 'SMB Shares'

What is the expected result?
Not a crash

What happens instead of that?
Crash

Please provide any additional information below. Attach a screenshot if
possible.

This is an artifact of the refactor of ProvidedFileSystem to support Native providers in addition to extensions.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/249c490d402b0597ad432c279b31f23ccdf917c6

commit 249c490d402b0597ad432c279b31f23ccdf917c6
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Mar 29 06:03:38 2018

fix crash for native providers

This change fixes a crash when Native Filesystem Providers call the
Service::RequestMount() function via the providers_menu in the CrOS
Files App.

Bug:  chromium:827023 
Test: manually verified on eve
Change-Id: I25ba6fb33fe9c9ae1a360368c0d8bb45728fc7a1
Reviewed-on: https://chromium-review.googlesource.com/972421
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546741}
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/extension_provider.cc
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/extension_provider.h
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/fake_extension_provider.cc
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/fake_extension_provider.h
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/provider_interface.h
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/249c490d402b0597ad432c279b31f23ccdf917c6/chrome/browser/chromeos/smb_client/smb_provider.h

Comment 2 by zentaro@chromium.org, May 14 2018

Labels: smb-native

Comment 3 by zentaro@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment