New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827022 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 526154



Sign in to add a comment

Write an initiator which selects a stable revision from which to start the Code Search builders

Project Member Reported by j...@chromium.org, Mar 29 2018

Issue description

We'll need this in order to provide Xrefs for multiple configurations in a sane way.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6ca03faefb98b381d91e956d6888be8986b489e3

commit 6ca03faefb98b381d91e956d6888be8986b489e3
Author: Joey Scarr <jsca@google.com>
Date: Wed Apr 04 01:31:39 2018

Add an initiator recipe to trigger the codesearch gen builders.

This new builder ensures that the Kythe index packs are generated at the same revision.

Bug:  827022 
Change-Id: I855c3c58a9d0fd7ef621eca3e8cb581b102ae664
Reviewed-on: https://chromium-review.googlesource.com/991552
Commit-Queue: Joey Scarr <jsca@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch.py
[add] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch_initiator.expected/basic.json
[modify] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/masters/master.chromium.infra.codesearch/master.cfg
[modify] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/README.recipes.md
[add] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android_with_revision.json
[add] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch_initiator.py
[add] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_with_revision.json
[modify] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/masters/master.chromium.infra.codesearch/slaves.cfg
[add] https://crrev.com/6ca03faefb98b381d91e956d6888be8986b489e3/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9e2447f47145b958b4cc1ba9b528c3263866470b

commit 9e2447f47145b958b4cc1ba9b528c3263866470b
Author: Aaron Gable <agable@chromium.org>
Date: Wed Apr 04 20:09:11 2018

Fix codesearch initiator to strip prefix from json

Gerrit JSON responses all start with a well-known prefix to combat
XSS exploits. The get_json() call needs to strip that prefix
before trying to parse the response. Luckily, this is a thing
we've run into many times before, so we already have support for
it built in to the url api!

R=flyboy, jsca

Bug:  827022 
Change-Id: Iddb462cb815177d7710dbbd7d0618d51c1e3a7f5
Reviewed-on: https://chromium-review.googlesource.com/996400
Reviewed-by: Alan Bram <flyboy@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/9e2447f47145b958b4cc1ba9b528c3263866470b/scripts/slave/recipes/chromium_codesearch_initiator.py
[modify] https://crrev.com/9e2447f47145b958b4cc1ba9b528c3263866470b/scripts/slave/recipes/chromium_codesearch_initiator.expected/basic.json

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/53a7a5918c46a58a5a94ac17bccc8b7d383d907d

commit 53a7a5918c46a58a5a94ac17bccc8b7d383d907d
Author: Joey Scarr <jsca@google.com>
Date: Thu Apr 05 01:10:11 2018

Turn off auto_reboot for the codesearch initiator builder.

It looks like the Linux build, which runs on the same slave as the initiator, is
failing because the machine is getting rebooted as it tries to start up.

Bug:  827022 
Change-Id: I943c0518c146f527c3a9cb246b708935da1c0a67
Reviewed-on: https://chromium-review.googlesource.com/996972
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>

[modify] https://crrev.com/53a7a5918c46a58a5a94ac17bccc8b7d383d907d/masters/master.chromium.infra.codesearch/master.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ce3bdc9e89bfac89875a991101ff4e8f5361cd30

commit ce3bdc9e89bfac89875a991101ff4e8f5361cd30
Author: Joey Scarr <jsca@google.com>
Date: Thu Apr 05 04:43:02 2018

Run the initiator script on its own machine.

I want to see if this fixes the error we've been seeing with the Linux build.

Bug:  827022 
Change-Id: Ic1b244c0a3012c7307edb101f5ff77665a111e87
Reviewed-on: https://chromium-review.googlesource.com/997036
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>

[modify] https://crrev.com/ce3bdc9e89bfac89875a991101ff4e8f5361cd30/masters/master.chromium.infra.codesearch/slaves.cfg

Comment 5 by j...@chromium.org, Apr 8 2018

Status: Verified (was: Started)

Sign in to add a comment