Write an initiator which selects a stable revision from which to start the Code Search builders |
||
Issue descriptionWe'll need this in order to provide Xrefs for multiple configurations in a sane way.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/9e2447f47145b958b4cc1ba9b528c3263866470b commit 9e2447f47145b958b4cc1ba9b528c3263866470b Author: Aaron Gable <agable@chromium.org> Date: Wed Apr 04 20:09:11 2018 Fix codesearch initiator to strip prefix from json Gerrit JSON responses all start with a well-known prefix to combat XSS exploits. The get_json() call needs to strip that prefix before trying to parse the response. Luckily, this is a thing we've run into many times before, so we already have support for it built in to the url api! R=flyboy, jsca Bug: 827022 Change-Id: Iddb462cb815177d7710dbbd7d0618d51c1e3a7f5 Reviewed-on: https://chromium-review.googlesource.com/996400 Reviewed-by: Alan Bram <flyboy@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9e2447f47145b958b4cc1ba9b528c3263866470b/scripts/slave/recipes/chromium_codesearch_initiator.py [modify] https://crrev.com/9e2447f47145b958b4cc1ba9b528c3263866470b/scripts/slave/recipes/chromium_codesearch_initiator.expected/basic.json
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/53a7a5918c46a58a5a94ac17bccc8b7d383d907d commit 53a7a5918c46a58a5a94ac17bccc8b7d383d907d Author: Joey Scarr <jsca@google.com> Date: Thu Apr 05 01:10:11 2018 Turn off auto_reboot for the codesearch initiator builder. It looks like the Linux build, which runs on the same slave as the initiator, is failing because the machine is getting rebooted as it tries to start up. Bug: 827022 Change-Id: I943c0518c146f527c3a9cb246b708935da1c0a67 Reviewed-on: https://chromium-review.googlesource.com/996972 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> [modify] https://crrev.com/53a7a5918c46a58a5a94ac17bccc8b7d383d907d/masters/master.chromium.infra.codesearch/master.cfg
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ce3bdc9e89bfac89875a991101ff4e8f5361cd30 commit ce3bdc9e89bfac89875a991101ff4e8f5361cd30 Author: Joey Scarr <jsca@google.com> Date: Thu Apr 05 04:43:02 2018 Run the initiator script on its own machine. I want to see if this fixes the error we've been seeing with the Linux build. Bug: 827022 Change-Id: Ic1b244c0a3012c7307edb101f5ff77665a111e87 Reviewed-on: https://chromium-review.googlesource.com/997036 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> [modify] https://crrev.com/ce3bdc9e89bfac89875a991101ff4e8f5361cd30/masters/master.chromium.infra.codesearch/slaves.cfg
,
Apr 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 4 2018