New issue
Advanced search Search tips

Issue 826990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

"Found disk" log warning spam from disk_mount_manager.cc

Project Member Reported by derat@chromium.org, Mar 29 2018

Issue description

I see a bunch of warnings like this in /var/log/chrome/chrome on a newly-booted ToT eve system:

[25409:25409:0320/165024.178737:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda
[25409:25409:0320/165024.223308:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda1
[25409:25409:0320/165024.251366:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda10
[25409:25409:0320/165024.893463:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda11
...
[25409:25409:0320/165025.094392:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda12
...
[25409:25409:0320/165025.313787:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda2
...
[25409:25409:0320/165025.592130:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda3
[25409:25409:0320/165025.796787:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda4
[25409:25409:0320/165025.954379:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda5
[25409:25409:0320/165026.054035:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda6
[25409:25409:0320/165026.129124:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda7
[25409:25409:0320/165026.201764:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda8
[25409:25409:0320/165026.239375:WARNING:disk_mount_manager.cc(617)] Found disk /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/sda9

These messages are non-actionable; it's unclear to me why finding a disk is a problem.

hashimoto@, I think that you added (or moved) this message long ago. Can I change it to DVLOG(1)?
 

Comment 1 by derat@chromium.org, Mar 29 2018

Sorry, that's actually from a Feb 21 lumpy image -- the timestamps should've been a giveaway. :-) The issue still stands, though.
This WARNING log was added to mount_library.cc in https://codereview.chromium.org/6674043, and I moved it to disk_mount_manager.cc in https://codereview.chromium.org/8499007 as part of libcros removal.
I think it's OK to remove it or change it to a DVLOG.

Comment 3 by derat@chromium.org, Apr 17 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c31c43d318183f4626dc3643d50db9b8c03e154

commit 0c31c43d318183f4626dc3643d50db9b8c03e154
Author: Daniel Erat <derat@chromium.org>
Date: Tue Apr 17 04:47:45 2018

chromeos: Remove "Found disk" warning messages.

Change DiskMountManagerImpl's "Found disk" warning messages
to DVLOG(1). I don't think that these indicate problems.

Bug:  826990 
Change-Id: I60a8ae1e032d209f4649d774ee4fb60d91842197
Reviewed-on: https://chromium-review.googlesource.com/1014376
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551245}
[modify] https://crrev.com/0c31c43d318183f4626dc3643d50db9b8c03e154/chromeos/disks/disk_mount_manager.cc

Comment 5 by derat@chromium.org, Apr 17 2018

Status: Fixed (was: Started)

Sign in to add a comment