New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826970 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: LayerTreeHostCopyRequestTestMultipleRequests.SkiaRenderer_RunSingleThread_OutOfOrderCallbacks



Sign in to add a comment

LayerTreeHostCopyRequestTestMultipleRequests.SkiaRenderer_RunSingleThread_OutOfOrderCallbacks is Flaky

Project Member Reported by Findit, Mar 28 2018

Issue description

Comment 1 by zmin@chromium.org, Apr 4 2018

Three test are flaky:
LayerTreeHostCopyRequestTestMultipleRequests.SkiaRenderer_RunMultiThread
LayerTreeHostCopyRequestTestMultipleRequests.SkiaRenderer_RunSingleThread
LayerTreeHostCopyRequestTestMultipleRequests.SkiaRenderer_RunMultiThread_OutOfOrderCallbacks

Comment 2 by zmin@chromium.org, Apr 4 2018

 Issue 826971  has been merged into this issue.

Comment 3 by zmin@chromium.org, Apr 4 2018

Labels: -Sheriff-Chromium
Owner: weiliangc@chromium.org
Status: Assigned (was: Available)
The CL has been reverted already, assign the issue to the owner.
Cc: xing...@intel.com enne@chromium.org
After investigation it seems to be a name collision that was added in adding filter support CL. The reverted CL adds the tests that runs that code path. cc'ing more people.
Cc: danakj@chromium.org shuqianz@chromium.org minch@chromium.org mtklein@chromium.org bsalomon@chromium.org robertphillips@chromium.org weiliangc@chromium.org
 Issue 826881  has been merged into this issue.
Cc: shend@chromium.org
 Issue 826974  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f3548a29f54fe55db4e32737410cda7639892d

commit e6f3548a29f54fe55db4e32737410cda7639892d
Author: Weiliang Chen <weiliangc@chromium.org>
Date: Mon Apr 09 16:54:36 2018

viz: Avoid Struct Name Collision by Making Nested Classes

This should fix the root issue found when trying to add pixel tests for
SkiaRenderer. This CL puts DrawRPDQParams as nested classes into each
renderer.

Bug:  826970 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If387abd00afdb19e9498fea843438da8e94aa31b
Reviewed-on: https://chromium-review.googlesource.com/1000543
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549200}
[modify] https://crrev.com/e6f3548a29f54fe55db4e32737410cda7639892d/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/e6f3548a29f54fe55db4e32737410cda7639892d/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/e6f3548a29f54fe55db4e32737410cda7639892d/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/e6f3548a29f54fe55db4e32737410cda7639892d/components/viz/service/display/skia_renderer.h

Status: Fixed (was: Assigned)

Sign in to add a comment