New issue
Advanced search Search tips

Issue 826958 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Apr 2018
Cc:
omrilio@chromium.org
x...@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Split-screen indicators positioned wrong when rotate while dragging.

Project Member Reported by sammiequon@chromium.org, Mar 28 2018 
1) Enter overview.
2) Hold on a window to drag. Splitscreen indicators show up.
3) Rotate while still finger on screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a2d04694e244864d1fc8eadfb51858130c4cded

commit 2a2d04694e244864d1fc8eadfb51858130c4cded
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Mar 29 01:26:30 2018

splitview: Properly show splitview indicators when rotated.

After rotate, SplitViewIndicatorView::Layout gets called, but width()
and height() return the wrong values. Set the widget to the correct
bounds on rotation, which will then call Layout with the correct width()
and height().

Test: manual
Bug:  826958 
Change-Id: Ibc243ab676fba7503370a38fe7bfb3e4edd25e4d
Reviewed-on: https://chromium-review.googlesource.com/985497
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546691}
[modify] https://crrev.com/2a2d04694e244864d1fc8eadfb51858130c4cded/ash/wm/splitview/split_view_drag_indicators.cc

Comment 2 by sammiequon@chromium.org, Apr 3 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment