New issue
Advanced search Search tips

Issue 826952 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

UDPSocketTest.ConnectRandomBind takes 35-50 seconds to execute, and so often times out

Project Member Reported by w...@chromium.org, Mar 28 2018

Issue description

UDPSocketTest.ConnectRandomBind sometimes takes ~40 seconds or less (e.g. see https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/15396), but other runs take ~50 seconds (see https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/15398).

Our per-test timeout is set to 45s on these bots, so this results in relatively frequent flakes.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
That test opens and then closes 1000 UDP sockets. 45ms per socket seems like really awful performance.

Comment 2 by w...@chromium.org, Mar 29 2018

Cc: -sergeyu@chromium.org
Owner: sergeyu@chromium.org
Status: Assigned (was: Started)
sergeyu: That does seem like pretty terrible performance, though this is under nested virtualization.  Running locally with QEMU+KVM I saw a ~100x improvement, suggesting that this is the IPI overhead biting us again, which makes sense given that this test will be running in lock-step with the network stack. Binding the ports in parallel, across multiple threads, may actually make it faster...
The test runs much faster locally (250ms). Will disable for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651bd00c856f9fa95ff574f37c37e7df3a2ee573

commit 651bd00c856f9fa95ff574f37c37e7df3a2ee573
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Apr 02 23:34:13 2018

Disable UDPSocketTest.ConnectRandomBind on Fuchsia

The test timeouts when running on bots with nested virtualization due
to slow IPIs and CPU contention.

Bug:  826952 
Change-Id: I2f8583922bf0591357dd1a0259c879df99b845c2
Reviewed-on: https://chromium-review.googlesource.com/990731
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547564}
[modify] https://crrev.com/651bd00c856f9fa95ff574f37c37e7df3a2ee573/net/socket/udp_socket_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94f2899d6a8a1fe6f36ed6cccda47277014f03e

commit b94f2899d6a8a1fe6f36ed6cccda47277014f03e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon May 07 18:17:12 2018

Enable UDPSocketTest.ConnectRandomBind on Fuchsia

Performance has been improved significantly after we've fixed
TSC clock support, so the test shouldn't timeout anymore.

Bug:  826952 
Change-Id: If65bb330c119ef32948a2b46f1a980d4a1a0644f
Reviewed-on: https://chromium-review.googlesource.com/1045561
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556501}
[modify] https://crrev.com/b94f2899d6a8a1fe6f36ed6cccda47277014f03e/net/socket/udp_socket_unittest.cc

Comment 7 by w...@chromium.org, Jan 20 (2 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment