New issue
Advanced search Search tips

Issue 826933 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 804949



Sign in to add a comment

GDPR Arc hide tos for manged user in oobe flow

Project Member Reported by lgcheng@google.com, Mar 28 2018

Issue description

Comment 1 by lgcheng@google.com, Mar 28 2018

Blocking: 804949
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849fc67a2f0235952bcbb1b6a58bb8ab81620852

commit 849fc67a2f0235952bcbb1b6a58bb8ab81620852
Author: lgcheng <lgcheng@google.com>
Date: Mon Apr 02 19:02:45 2018

Hide ToS view for managed user in OOBE.

This behavior is missing in OOBE flow.

Bug:  826933 
Bug: b/73338382

Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ccb4dc84469c4612c24cd6e5c387b4949277b13
Reviewed-on: https://chromium-review.googlesource.com/988807
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#547480}
[modify] https://crrev.com/849fc67a2f0235952bcbb1b6a58bb8ab81620852/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/849fc67a2f0235952bcbb1b6a58bb8ab81620852/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc
[modify] https://crrev.com/849fc67a2f0235952bcbb1b6a58bb8ab81620852/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 9 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aba86a2070479a967589f9bfa28c2faad1ec980b

commit aba86a2070479a967589f9bfa28c2faad1ec980b
Author: lgcheng <lgcheng@google.com>
Date: Mon Apr 09 16:27:57 2018

Hide ToS view for managed user in OOBE.

This behavior is missing in OOBE flow.

TBR=xiyuan@chromium.org

Bug:  826933 
Bug: b/73338382

Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ccb4dc84469c4612c24cd6e5c387b4949277b13
Reviewed-on: https://chromium-review.googlesource.com/988807
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#547480}(cherry picked from commit 849fc67a2f0235952bcbb1b6a58bb8ab81620852)
Reviewed-on: https://chromium-review.googlesource.com/993292
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/branch-heads/3359@{#621}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/aba86a2070479a967589f9bfa28c2faad1ec980b/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/aba86a2070479a967589f9bfa28c2faad1ec980b/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc
[modify] https://crrev.com/aba86a2070479a967589f9bfa28c2faad1ec980b/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h

Comment 4 by lgcheng@google.com, Apr 13 2018

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in M66.0.3359.149 10452.81 stable paine. Play store ToS view is not shown to managed user; unmanaged users would see it.

Sign in to add a comment