New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826921 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Buildbucket & tricium plugin: refactor auth state since if it's no longer shared

Project Member Reported by qyears...@chromium.org, Mar 28 2018

Issue description

As far as I understand, the authentication state (such as the oauth2 bearer token) would be stored in a same cr-buildbucket-client element object which originally may be reused for different change pages.

Then, I believe when buildbucket.js was simplified at the end of 2017 (https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/814619) it was changed so that cr-buildbucket-view and cr-buildbucket-client are always created fresh when a new change is viewed.

So, I think it no longer makes sense to have a property called _sharedAuthState which is supposed to maybe persist across different changes.

Same for tricium plugin.
 
Components: Infra>CodeAnalysis
Status: WontFix (was: Available)
I tried this; it didn't turn out to be a good idea. The shared auth state is reused in buildbucket for both the tryjob picker and view element.

Sign in to add a comment