New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826918 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

platform_ToolchainOptions test failure on guado

Project Member Reported by mkarkada@chromium.org, Mar 28 2018

Issue description

Cc: lasoren@chromium.org
Owner: manojgupta@chromium.org
Need to whitelist rtanalytics_main (Details at bug  b/73422412).
Labels: M-67
Note that we also merged the use of libstdc++ for rtanalytics_main back to M66. Not sure if this change needs to be merged back as well?
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/708f6152760be4774d6e83e893e0b5ce68e28867

commit 708f6152760be4774d6e83e893e0b5ce68e28867
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Mar 30 02:51:33 2018

platform_ToolchainOptions: Whitelist rtanalytics_main.

rtanalytics_main is needed to be built with libstdc++
because of bug b:73422412 .

BUG= chromium:826918 
TEST=platform_ToolchainOptions passes on guado.

Change-Id: Iaf2f62afb50b51eab5de8d92dd79891f0d2af011
Reviewed-on: https://chromium-review.googlesource.com/984864
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/708f6152760be4774d6e83e893e0b5ce68e28867/client/site_tests/platform_ToolchainOptions/libstdcxx_whitelist

Cc: josa...@chromium.org
Labels: Merge-Request-66
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 30 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Status: Assigned (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 2 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c7b8c80546ba7a2de22dbcae07a8a63fdb4ea11d

commit c7b8c80546ba7a2de22dbcae07a8a63fdb4ea11d
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Apr 02 17:43:32 2018

platform_ToolchainOptions: Whitelist rtanalytics_main.

rtanalytics_main is needed to be built with libstdc++
because of bug b:73422412 .

BUG= chromium:826918 
TEST=platform_ToolchainOptions passes on guado.

Change-Id: Iaf2f62afb50b51eab5de8d92dd79891f0d2af011
Reviewed-on: https://chromium-review.googlesource.com/984864
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 708f6152760be4774d6e83e893e0b5ce68e28867)
Reviewed-on: https://chromium-review.googlesource.com/987612
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/c7b8c80546ba7a2de22dbcae07a8a63fdb4ea11d/client/site_tests/platform_ToolchainOptions/libstdcxx_whitelist

Project Member

Comment 9 by sheriffbot@chromium.org, Apr 3 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-66
Status: Verified (was: Assigned)
Passed on Guado at R67-10539.0.0.

Sign in to add a comment