New issue
Advanced search Search tips

Issue 826908 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: DCHECK when opening Character Viewer from Omnibox

Project Member Reported by lgrey@chromium.org, Mar 28 2018

Issue description

What steps will reproduce the problem?
(1) Run a Polychrome browser with --enable-features=ViewsBrowserWindows and DCHECK enabled
(2) Focus the Omnibox
(3) Command + Control + Spacebar

What is the expected result?
Character viewer appears

What happens instead?
DCHECK in Crashpad and crash

Root cause:
In [BrowserCrApplication sendEvent:], we log the event description to a crash key. However, this particular event returns a string of length 1 and contents NUL for event.characters, which gets baked into the event's description. Since the description contains an embedded NUL, Crashpad DCHECKs.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38b410255a52fd1bceda29a680de3e52857b091

commit b38b410255a52fd1bceda29a680de3e52857b091
Author: Leonard Grey <lgrey@chromium.org>
Date: Wed Mar 28 22:24:10 2018

[Mac] Replace embedded NULs in event description when creating crash key

Bug:  826908 
Change-Id: Ib160f35ef61043183e769a5b57f0988bc383241a
Reviewed-on: https://chromium-review.googlesource.com/985077
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546623}
[modify] https://crrev.com/b38b410255a52fd1bceda29a680de3e52857b091/chrome/browser/chrome_browser_application_mac.mm

Comment 2 by lgrey@chromium.org, Mar 29 2018

Status: Fixed (was: Started)

Sign in to add a comment