New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826885 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Apr 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Auto-revert: Update instruction for how to deal with false-positives.

Project Member Reported by chanli@chromium.org, Mar 28 2018 
Checking the survey https://goo.gl/forms/iPQbwFyo98N9tJ7o1, there is one suggestion saying 

"The instructions for how to undo a false-positive findit auto-revert are confusing: "If it is a false positive, please revert and report it" might better be stated as "If it is a false positive, please reland the falsely identified and reverted CL, and report it". There was no "revert" button in gerrit to revert the auto-revert. Rather, "reland" the reverted CL is the option I found and took today."
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/80f904d1b9a99e6db23940dc5d8b1e1079f1d223

commit 80f904d1b9a99e6db23940dc5d8b1e1079f1d223
Author: Chan <chanli@chromium.org>
Date: Mon Apr 16 19:39:16 2018

[Findit] Update instruction for how to deal with false-positives.

For an auto-revert of Findit, there is no 'Revert' button on the page. So instead of 'revert' a false positive revert, it should actually be 'reland' the original CL.

Bug:  826885 
Change-Id: Iff99c9e31acfac052e0143b62fa07fcf8884ba16
Reviewed-on: https://chromium-review.googlesource.com/1014342
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/80f904d1b9a99e6db23940dc5d8b1e1079f1d223/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/80f904d1b9a99e6db23940dc5d8b1e1079f1d223/appengine/findit/services/gerrit.py

Comment 2 by chanli@chromium.org, Apr 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment