New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826881 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 826970
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Some RenderPixelTests crashes on linux-chromeos-dbg

Project Member Reported by afakhry@chromium.org, Mar 28 2018

Issue description

linux-chromeos-dbg: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4928 has three test failures:

RendererPixelTest/2.EnlargedRenderPassTextureWithAntiAliasing
RendererPixelTest/2.EnlargedRenderPassTexture
RendererPixelTest/2.SimpleGreenRect_NonRootRenderPass

For example:

[ RUN      ] RendererPixelTest/2.EnlargedRenderPassTexture
Received signal 11 SEGV_MAPERR 00003f800008
#0 0x7f7fdb2e57dd base::debug::StackTrace::StackTrace()
#1 0x7f7fdb2e3eec base::debug::StackTrace::StackTrace()
#2 0x7f7fdb2e5268 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f7fdb70f330 <unknown>
#4 0x7f7fd6ed4797 SkRefCntBase::getRefCnt()
#5 0x7f7fd6ed4669 SkRefCntBase::ref()
#6 0x7f7fd6eccad3 SkSafeRef<>()
#7 0x7f7fd6ecf4d9 sk_sp<>::sk_sp()
#8 0x7f7fd6f155d4 viz::SkiaRenderer::DrawRenderPassQuad()
  r8: 00007ffc62e25f08  r9: 00007ffc62e25798 r10: 00007ffc62e25800 r11: 0000000000000000
 r12: 000000000048a0e0 r13: 00007ffc62e294c0 r14: 0000000000000000 r15: 0000000000000000
  di: 000000003f800008  si: 00007ffc62e25cc0  bp: 00007ffc62e25920  bx: 0000000000000000
  dx: 00007ffc62e25920  ax: 000000003f800008  cx: 00000000fffffffd  sp: 00007ffc62e25920
  ip: 00007f7fd6ed4797 efl: 0000000000010293 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 000000003f800008
[end of stack trace]
Calling _exit(1). Core file will not be generated.


Suspecting: https://chromium-review.googlesource.com/c/chromium/src/+/862725.

+weiliangc@ can you please take a look?
 
Summary: Some RenderPixelTests crashes on linux-chromeos-dbg (was: RenderPixelTest crashes on linux-chromeos-dbg)
Cc: bsalomon@chromium.org
Yeah those tests are added with the new CL. Looks like an error in getting the Skia ref counted pointer?

Not sure who else to cc on Skia team. Looks like a linux cros debug build, I'll try locally as well.
Build [1] is still failing. Any potential fix soon? We might have to revert the CL if it's going to take a while.

[1]: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4929

Comment 4 by hcm@chromium.org, Apr 3 2018

Cc: mtklein@chromium.org robertphillips@chromium.org
I saw the revert happened while bsalomon & I were OOO. cc a couple more Skia folks in case they have ideas/can help on issues with test & ref counted pointer...
Mergedinto: 826970
Status: Duplicate (was: Assigned)
I think I figured out how to fix it, not really skia related more of the general C++ problem. Merging into one bug. 

Sign in to add a comment