New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 826867 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Create rendering path for AR to render camera frames

Project Member Reported by lincolnfrog@chromium.org, Mar 28 2018

Issue description

ARCore integration requires a way to render the camera texture - need to pass a mailbox holder to the renderer so the texture can be rendered by the GPU prior to the RAF.
 
IL, along with the version, after other browsers where you
Description: Show this description
Description: Show this description
Summary: Create rendering path for AR to render camera frames (was: Create rendering path for AR to give camera frames to renderer)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24880023b318f8c0c0286a6d58dcd0e8ce438547

commit 24880023b318f8c0c0286a6d58dcd0e8ce438547
Author: Max Rebuschatis <lincolnfrog@chromium.org>
Date: Sat Apr 14 00:23:27 2018

Split MailboxToSurfaceBridge surface and context

Separate MailboxToSurfaceBridge::CreateSurface to allow
surface and context creation to be done separately.
This change allows ARCore to use MBTSB without a surface.

Bug:  826867 
Change-Id: I346aa3b3285b96c71e193a1aeb5a35aba384e28e
Reviewed-on: https://chromium-review.googlesource.com/1011385
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550827}
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/mailbox_to_surface_bridge.h
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/vr_shell_gl.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24880023b318f8c0c0286a6d58dcd0e8ce438547

commit 24880023b318f8c0c0286a6d58dcd0e8ce438547
Author: Max Rebuschatis <lincolnfrog@chromium.org>
Date: Sat Apr 14 00:23:27 2018

Split MailboxToSurfaceBridge surface and context

Separate MailboxToSurfaceBridge::CreateSurface to allow
surface and context creation to be done separately.
This change allows ARCore to use MBTSB without a surface.

Bug:  826867 
Change-Id: I346aa3b3285b96c71e193a1aeb5a35aba384e28e
Reviewed-on: https://chromium-review.googlesource.com/1011385
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550827}
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/mailbox_to_surface_bridge.h
[modify] https://crrev.com/24880023b318f8c0c0286a6d58dcd0e8ce438547/chrome/browser/android/vr/vr_shell_gl.cc

Labels: Proj-XR-AR
Status: Fixed (was: Assigned)
Labels: M-68 Test-Complete
Components: Blink>WebXR

Sign in to add a comment