+screencasts: actual vs expected

Deleted: actual.mov 502 KB

	actual.mov 502 KB View Download

Deleted: expected.mov 544 KB

	expected.mov 544 KB View Download

This is the same basic problem as issue 712248 - Views dragging behavior has the black line instead of an animation. Assigning to lgrey@ for M68.

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Hello lgrey@: I noticed that the animation is also missing on the Bookmarks Bar when moving items on it or with the Find-In-Page Bubble when it moves to side. Should I file separate reports for them or can they addressed with this bug too? Thanks.

The bookmark buttons are issue 712248.

I don't totally understand what you mean with the Find-in-Page bubble. How could I repro?

Thanks!

Thanks for the report number for bookmark button issue.

With "Find-in-Page bubble" I mean the CMD-F bubble. It moves with a nice animation in Cocoa when it overlaps the search result. Please find enclosed a screencast (left Cocoa/right Macviews). Thanks :)

Deleted: Find_Cocoa_vs_MacViews.mov 3.0 MB

	Find_Cocoa_vs_MacViews.mov 3.0 MB View Download

Thanks, that's really helpful! Could you please file it separately?

Of course, done: issue 840421

Any progress here?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/debc03f2d888caac5d5e23e411c57ec4adcef8df

commit debc03f2d888caac5d5e23e411c57ec4adcef8df
Author: Leonard Grey <lgrey@chromium.org>
Date: Wed May 30 22:15:42 2018

Keep track of dragged item index in ToolbarActionsBar

This is set up for animated action dragging. If an action is in the process
of being dragged from the main bar to the overflow or vice versa, it allows
the original bar to keep track of what's being dragged despite not having
an active drag session.

Bug: 826865
Change-Id: Id86dc6c2475ada376abe37fe7169b5f9d4d42e52
Reviewed-on: https://chromium-review.googlesource.com/1079287
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563019}
[modify] https://crrev.com/debc03f2d888caac5d5e23e411c57ec4adcef8df/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/debc03f2d888caac5d5e23e411c57ec4adcef8df/chrome/browser/ui/toolbar/toolbar_actions_bar.h
[modify] https://crrev.com/debc03f2d888caac5d5e23e411c57ec4adcef8df/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/debc03f2d888caac5d5e23e411c57ec4adcef8df/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

 Issue 851902  has been merged into this issue.

Video of https://chromium-review.googlesource.com/c/chromium/src/+/1091416 in action attached.

Deleted: bac_drag.mov 42.9 KB

	bac_drag.mov 42.9 KB View Download

Thanks lgrey@. Looks great 👍

Not sure if possible, but it would be nice, if the icon could stay on the toolbar during drag & drop and move not under the cursor :)

Will your fix also consider the Drag & Drop in the Settings Menu when the Extension icon is hidden in it?

Thanks :)

> Not sure if possible, but it would be nice, if the icon could stay on the toolbar during drag & drop and move not under the cursor :)

This has some UX issues since unlike Cocoa it can be dragged off the bar (there's also technical reasons that make it harder to adapt the current views behavior to do that, which are surmountable, but would nevertheless be time-consuming).

> Will your fix also consider the Drag & Drop in the Settings Menu when the Extension icon is hidden in it?
If you're asking what I think, yes.

Thanks for your feedback lgrey@. 

***Mass UI Triage***
As per dev comments.Adding labels for expert review.