New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 826862 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
ftirelo@chromium.org
█ spqc...@chromium.org
tmartino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove ParentWidget in AutofillPopupBaseView

Project Member Reported by spqc...@chromium.org, Mar 28 2018 
parent_widget is currently used to close the autofill popup base view when the window is moved. See if you can remove it

Comment 1 by ma...@chromium.org, Jul 17

Cc: ftirelo@chromium.org spqc...@chromium.org tmartino@chromium.org
Owner: ftirelo@chromium.org
Fabio/Tommy, is this something you've tackled in your refactors?

Comment 2 by ftirelo@chromium.org, Jul 17 

AFAICT parent_widget needs to exist while the Cocoa browser exists. 

spqchan@: can you please confirm?

Comment 3 by ftirelo@chromium.org, Jul 17

Owner: spqc...@chromium.org
Reassigning to spqchan@ who has the full context on this.

Comment 4 by spqc...@chromium.org, Oct 1

Owner: ----
Status: Untriaged (was: Assigned)
The Cocoa browser have a parent widget, which is why we want to get rid of it

See https://cs.chromium.org/chromium/src/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc?rcl=d873c2c20c6434611cb159092295cdce6286a1a9&l=63
►

Sign in to add a comment